Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discarding rawtx topic as transaction #74

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

Alex-Werner
Copy link

Issue being fixed or feature implemented

This is a followup on #69, it's not only rawtxlock but also rawtx that is being sent as txbuffer from ZMQ socket.
This PR modifies previous in order to encompass both of these cases.

What was done?

  • provided hotfix that abandon trying to parse such message.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

Cofresi
Cofresi previously approved these changes Jan 27, 2021
Copy link

@Cofresi Cofresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@Cofresi Cofresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Alex-Werner Alex-Werner merged commit e02247c into master Jan 28, 2021
@Alex-Werner Alex-Werner deleted the fix/topic-in-txbuf branch January 28, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants