Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport masternodebroadcast to v0.12.0.x #907

Merged
merged 1 commit into from
Jul 29, 2016
Merged

Backport masternodebroadcast to v0.12.0.x #907

merged 1 commit into from
Jul 29, 2016

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jul 7, 2016

see 40f0d1f #741 and c96284a #744 for more info
@thelazier

@thelazier
Copy link

Thank you so much 👍
Live on mainnet for electrum.dash.siampm.com (electrum-dash-server) now.

@thelazier
Copy link

Found many Misbehaving with this line
CMasternodePing::CheckAndUpdate - Signature rejected, too far into the past ...
So, I guess prior version relay ping without checking sigtime, is this worth fixing on v0.12.0.x ?
(ref: https://github.com/UdjinM6/dash/blob/256e02f760accccd0895bc1ef58eb53f69230fdd/src/masternode.cpp #L379 and #L479 )

@UdjinM6
Copy link
Author

UdjinM6 commented Jul 11, 2016

@thelazier Probably. But 1) I'm not quite sure what is causing this and 2) definitely not in this PR ;)

@schinzelh
Copy link

utACK

@schinzelh schinzelh merged commit e6da1fa into dashpay:v0.12.0.x Jul 29, 2016
@UdjinM6 UdjinM6 deleted the masternodebroadcast120 branch August 28, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants