Refactor/fix IX & Implement ixnotify #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otify to trigger external script
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #747 I noticed that notifications were acting strange BUT turned out that was not their own fault, instead IX seems to be broken a bit (i.e. sometimes it doesn't confirm because many votes came faster than lock the request itself). I tried to fix this and refactored code a bit to make it more DRY and simpler to read. And with that I got these "err... what?" moments so I need some help here, especially in
//?????parts ;)ixnotifypart is the same as in #747, it just moved inside ofUpdateLockedTransaction