Fix rpc-tests #720
Closed
Fix rpc-tests #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged all of them, many thanks! Let's see if Travis agrees :) |
|
thanks! travis most likely will complain though because there is no setup step for dash_hash yet... :/ |
|
Yep, dash_hash not found :-) |
|
I actually have a fix for this UdjinM6@9892813 ;) |
|
It fails at https://github.com/dashpay/dash/blob/v0.12.1.x/qa/rpc-tests/proxy_test.py#L59 - guessing without looking deeper: something with IPv6 is broken, as conf3 is the only one using IPv6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on PRs #715-#719
Requires https://github.com/dashpay/dash_hash to be installed (we need to fix gitian to do this too, not part of this PR).