feat(rpc): Tweak protx info to be able to show info for a specific block
#4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
|
Is this going to be be part of a future release now or is it not required anymore? |
|
@UdjinM6 can you get this up to date and add tests? (should also add release notes) |
UdjinM6
force-pushed
the
protxinfo_hash
branch
from
8620e2e to
1bb9f3a
Compare
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
protxinfo_hash
branch
from
1bb9f3a to
eade1e0
Compare
UdjinM6
changed the title
protx info to be able to show info for a specific blockprotx info to be able to show info for a specific block
|
@PastaPastaPasta With #5607 merged and a fixed |
UdjinM6
force-pushed
the
protxinfo_hash
branch
from
eade1e0 to
befe13a
Compare
knst
reviewed
Dec 12, 2023
UdjinM6
force-pushed
the
protxinfo_hash
branch
from
befe13a to
7a00bfe
Compare
|
@knst Applied most of suggestions, thanks! 👍 |
UdjinM6
force-pushed
the
protxinfo_hash
branch
from
7a00bfe to
9607cf8
Compare
|
fixed in 9f72012 |
PastaPastaPasta
approved these changes
Feb 7, 2024
|
Should this be under the 20.1 milestone? |
|
Good catch! fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.