Backport Bitcoin PR#9183: Final Preparation for main.cpp Split #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow NotifyHeaderTip to be called from an AcceptBlockHeader wrapper function without holding cs_main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of Bitcoin PR bitcoin#9183.
This is the last step in preparation for
main.{h,cpp}split.The original PR description follows.
Based on bitcoin#8930, the only thing left to do after this to split main.cpp into main and net_processing is a single move-only commit.
After bitcoin#8930, the only remaining changes are tweaks to pull header-processing-logic out of net code and into a function exposed through main.h.