Update documentation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cofresi
requested changes
Jan 3, 2019
README.md
Outdated
|
|
||
| ## Getting Started | ||
|
|
||
| This library is distributed in both the npm and bower packaging systems. | ||
|
|
||
| ```sh | ||
| npm install dashcore-lib | ||
| npm install dashcore-payment-protocol |
There was a problem hiding this comment.
npm install @dashevo/dashcore-lib
npm install @dashevo/dashcore-payment-protocol
There was a problem hiding this comment.
Nice catch! Should be fixed in both files now.
Cofresi
requested changes
Jan 3, 2019
| bower install bitcore-lib --save | ||
| bower install bitcore-payment-protocol --save | ||
| npm install dashcore-lib | ||
| npm install dashcore-payment-protocol | ||
| ``` |
There was a problem hiding this comment.
npm install @dashevo/dashcore-lib
npm install @dashevo/dashcore-payment-protocol
| Here the merchant's server will construct the payment details message: | ||
|
|
||
| ```javascript | ||
| var PaymentProtocol = require('bitcore-payment-protocol'); | ||
| var PaymentProtocol = require('dashcore-payment-protocol'); | ||
| var now = Date.now() / 1000 | 0; | ||
|
|
There was a problem hiding this comment.
var PaymentProtocol = require('@dashevo/dashcore-payment-protocol');
Cofresi
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13, so that should be merged first.
Please use "Squash and Merge option" when merging.