Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: generates Dart language clients #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cloudwheels
Copy link

Generate dart platform & core grpc clients using the protocol buffer complier (protoc) in the image thethingsindustries/protoc

How Has This Been Tested?

Successfully generates clients which have been used to implement methods in a dart library

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov
Copy link
Member

shumkov commented Feb 22, 2021

Thank you for PR! The name of it must follow https://www.conventionalcommits.org/en/v1.0.0/

@cloudwheels cloudwheels changed the title feature: generate Dart clients feat: generates Dart language clients Feb 22, 2021
@cloudwheels cloudwheels force-pushed the feature/cloudwheels-add-dart-clients branch from 14750a2 to e78e6a5 Compare February 22, 2021 09:51
@cloudwheels
Copy link
Author

@shumkov thanks - I have renamed commit from "feature: ..." to "feat: ..." - checks now passing!

@shumkov
Copy link
Member

shumkov commented Feb 22, 2021

@cloudwheels You also need to commit generated code and wrap it to dart package manager packet

@shumkov
Copy link
Member

shumkov commented Dec 15, 2021

@cloudwheels this repo is moved to https://github.com/dashevo/platform/tree/v0.22-dev/packages/dapi-grpc so please recreate your PR there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants