Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Log message when no listener for event #189

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

otothea
Copy link
Contributor

@otothea otothea commented Sep 5, 2019

Fixes #168 . This adds a log message when a responder or subscriber receives an event that it does not have a listener for. Logging is based on the cote log option and can be overridden at the Component level.

@coveralls
Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 7f761da on otothea:feature/log-missing-event-types into 955b853 on dashersw:master.

Copy link
Owner

@dashersw dashersw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the dist folder from your PR? I add them as a new commit before publishing a new version.

src/components/component.js Outdated Show resolved Hide resolved
@otothea otothea force-pushed the feature/log-missing-event-types branch from cab9f65 to 7f761da Compare September 27, 2019 01:51
@dashersw
Copy link
Owner

@otothea thank you! before I merge it, could you also add a section to the readme about this option?

@otothea otothea force-pushed the feature/log-missing-event-types branch from 7f761da to f8f1dbe Compare September 28, 2019 14:40
@otothea
Copy link
Contributor Author

otothea commented Sep 28, 2019

@dashersw I added the line to the readme. Unfortunately the Travis CI build failed due to what looks like a memory issue. I'm not sure how to retry it.

@dashersw dashersw merged commit c517ae2 into dashersw:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log a warning to the console if there are no handlers for a specific event
3 participants