docs: Stop suggest calling stub_with at compilation time
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs are still slightly suggesting that `stub_with` can be used just as `defmock` function in the `test_helper.exs` file, which is not true. dashbitco#122 was not enough to prevent devs from doing that mistake again. Moreover, if a developer does it, the `stub_with` call in the test helper won't raise any error (even though it has no effect); only later on in the test files they will meet unhelpful errors like `no expectation defined for ...`, making the root cause hard to discover. Let's help avoiding it.
|
💚 💙 💜 💛 ❤️ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs are still slightly suggesting that
stub_withcan be used just asdefmockfunction in thetest_helper.exsfile, which is not true. #122 was not enough to prevent devs from doing that mistake again.Moreover, if a developer does it, the
stub_withcall in the test helper won't raise any error (even though it has no effect); only later on in the test files they will meet unhelpful errors likeno expectation defined for ..., making the root cause hard to discover.Let's help avoiding it.