Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error when acking on a closed channel #122

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Improve error when acking on a closed channel #122

merged 1 commit into from
Feb 16, 2023

Conversation

whatyouhide
Copy link
Collaborator

See #106.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 497b1424c8199419dd1b7e65922419631e1d62f9-PR-122

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.737%
Totals Coverage Status
Change from base Build ac61bbd364477420596ff557dc9907cab382bfbb: 0.2%
Covered Lines: 216
Relevant Lines: 228
💛 - Coveralls

@whatyouhide whatyouhide mentioned this pull request Feb 16, 2023
Open
@whatyouhide whatyouhide merged commit d90814d into main Feb 16, 2023
@whatyouhide whatyouhide deleted the al/better-ack-error branch February 16, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whatyouhide @coveralls @josevalim