Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Goth v1.3+ #96

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Require Goth v1.3+ #96

merged 2 commits into from
Sep 7, 2023

Conversation

mcrumm
Copy link
Collaborator

@mcrumm mcrumm commented Sep 6, 2023

Closes #95

@mcrumm mcrumm requested a review from wojtekmach September 6, 2023 19:24
wojtekmach
wojtekmach approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcrumm mcrumm merged commit e794829 into main Sep 7, 2023
@mcrumm mcrumm deleted the mc-goth branch September 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmach wojtekmach wojtekmach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning due to Goth.Token.for_scope()
2 participants
@mcrumm @wojtekmach