Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPaletteEditor: hide hotcue number column for track palette #52

Merged
merged 1 commit into from
Apr 2, 2020
Merged

ColorPaletteEditor: hide hotcue number column for track palette #52

merged 1 commit into from
Apr 2, 2020

Conversation

Be-ing
Copy link

@Be-ing Be-ing commented Mar 30, 2020

It has no meaning in this context.

@Be-ing Be-ing mentioned this pull request Mar 30, 2020
Merged
daschuer
daschuer requested changes Mar 30, 2020
View reviewed changes
Copy link
Owner

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in the target PR the editor edits a type independent palette.
If you edit a palette from the track table edit button that is also used as Hotcue, the column is relevant. I like to keep it.

@daschuer
Copy link
Owner

daschuer commented Apr 2, 2020

Ok, since a majority prefers this patch I will merge this now.

@daschuer daschuer merged commit 3126268 into daschuer:color_preferences Apr 2, 2020
@Be-ing Be-ing deleted the color_preferences_hide_hotcue_number branch April 5, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @daschuer