Flag defaulted cue colors #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
force-pushed
the
new_colors_impl2
branch
from
b0b026c to
73339cf
Compare
|
The rebased branch, fixing my merge fault is here btw: |
Holzhaus
reviewed
Nov 23, 2019
src/track/cue.h
Outdated
| @@ -31,6 +31,7 @@ class Cue : public QObject { | |||
|
|
|||
| static constexpr double kNoPosition = -1.0; | |||
| static const int kNoHotCue = -1; | |||
| static const QRgb kDefaultDbColorValue = 0xFF000000; // Black | |||
There was a problem hiding this comment.
I know this isn't going to be displayed, but I'd still prefer making the DB column NULLable and using NULL as the default cue color.
There was a problem hiding this comment.
A null-abble column does not come without costs. It is an extra byte per column an null checking everywhere.
The migration will also require a new color column.
Not sure if this is worth.
If you think we need black as a color, we may use 0, black transparent, or 0x01000000 almost black transparent.
Prevent infinite loop when decoding corrupt MP3 files
# Conflicts: # CHANGELOG.md
- Preserve existing properties - Replace missing extra properties
daschuer
force-pushed
the
new_colors_impl2
branch
from
b5075f2 to
d314ac3
Compare
Happy New Year 2020!
Use qobject_cast for accessing the sender() of received signals
Fix a debug assertion if the track is recognized, but no MusicBrainz recordings have been found.
Abort pending network replies on client-side timeouts instead of (unsafely) deleting them. The network reply will be deleted later when receiving the corresponding finished signal.
...instead of with an empty string. Both work, but NULL is more explicit.
...to consider not only embedded cover art but also image files in the folder of the track's file. Otherwise the source of the cover info would be reset to UNKNOWN.
Removes redundant code out of TrackDAO that doesn't belong there!
Co-Authored-By: Jan Holthuis <[email protected]>
Denon MC6000MK2: Fix ESLint warnings
JoyMIDI Linter Fixes
shoutcast_internal always 0 bug in master
Soundless joyMIDI: Mapping for joyMIDI
Apply some eslint fixes
.eslintrc.json: Add rule for indentation style
Fixes this warning:
src/util/db/dbnamedentity.h:33:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
QString normalizedName(normalizeName(name));
^
src/controllers/controllerinputmappingtablemodel.cpp:186:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/controllers/controlleroutputmappingtablemodel.cpp:154:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/controllers/controllerpresetfilehandler.cpp:39:5: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/effects/lv2/lv2manifest.cpp:45:17: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/effects/lv2/lv2manifest.cpp:50:17: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/library/browse/browsetablemodel.cpp:301:5: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/library/crate/cratefeature.cpp:725:5: warning: unused QList<QString> [-Wclazy-unused-non-trivial-variable]
src/musicbrainz/musicbrainzclient.cpp:139:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/preferences/dialog/dlgprefdeck.cpp:118:5: warning: unused QLocale [-Wclazy-unused-non-trivial-variable]
src/preferences/dialog/dlgprefeq.cpp:389:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/preferences/dialog/dlgprefeq.cpp:413:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
src/skin/legacyskinparser.cpp:1991:5: warning: unused QDomNode [-Wclazy-unused-non-trivial-variable]
src/test/coverartutils_test.cpp:53:5: warning: unused QImage [-Wclazy-unused-non-trivial-variable]
src/util/db/dbnamedentity.h:33:9: warning: unused QString [-Wclazy-unused-non-trivial-variable]
This fixes a regression introduced in commit da19958 which made the control picker use the normal control instead of the _set_default one.
controllers/controlpickermenu: Fix reset controls not being used
Add missing override and remove unused variables
Fix disappearing fader handles for Deere skin
daschuer
pushed a commit
that referenced
this pull request
Jul 14, 2020
Adopt windowForWidget() from qtbase
|
This PR is marked as stale because it has been open 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows a possible solution for the default color problem discussed in mixxxdj#2345