Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BLS config #1024

Merged
merged 10 commits into from
Mar 16, 2023
Merged

Update BLS config #1024

merged 10 commits into from
Mar 16, 2023

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Mar 15, 2023 •
edited
Loading

  1. Update the EthBlockGasLimit from 10_000_000 to 20_000_000.
  2. The BLS verification consumed 900w gas according to my test and the remaining block gas(at least 1000w gas) is sufficient for the pre-precompile contract operations.

This was linked to issues Mar 15, 2023
Update BLS precompile gas #995
Closed
Pubkeys.len < 512 #1021
Closed
@boundless-forest boundless-forest requested a review from hujw77 March 15, 2023 08:12
@boundless-forest boundless-forest marked this pull request as ready for review March 15, 2023 08:12
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
hujw77
hujw77 previously approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@hujw77 hujw77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aurexav aurexav merged commit 478f126 into main Mar 16, 2023
@aurexav aurexav deleted the bear-update-bls-gas branch March 16, 2023 06:18
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Check 41ad354 pangolin-dev

Check runtime version





Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          

Check 41ad354 darwinia-dev



Check runtime version








Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          

Check 41ad354 crab-dev



Check runtime version








Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          

Check 41ad354 pangoro-dev



Check runtime version








Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
          


  
    
  
  

    
  boundless-forest 

      pushed a commit
      that referenced
      this pull request

    
      Aug 1, 2023
    
    

      


  

    

      


  

      
        @koushiro
  





      

        
          Fix docs CI (#1024)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          2055e2c
        
      

    

  

    

      
* Fix docs CI

* fix cargo doc warnings

    




    

  











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @aurexav
  
    aurexav



          
            
              
            
          
          aurexav left review comments

        

        

          

  
      @hujw77
  
    hujw77



          
            
              
            
          
          hujw77 left review comments

        

      

          

  
      @hackfisher
  
    hackfisher


                Awaiting requested review from hackfisher


        
      


      






    

  


      
  

    Assignees
  



        

      

        

  
      @boundless-forest
  
    boundless-forest
    

      








      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.


  
    
            
        Pubkeys.len < 512

    
            
        Update BLS precompile gas 


  


    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @boundless-forest 
        
          @hujw77 
        
          @aurexav