This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackfisher
reviewed
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AsceticBear please help review this.
OrderReward(LaneId, MessageNonce, RewardItem<T::AccountId, BalanceOf<T, I>>), | ||
/// Reward distribute of the order. \[lane_id, message_nonce, to_treasury, to_slot_relayer, | ||
/// to_message_relayer, to_confirm_relayer\] | ||
OrderReward( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JayJay1024 Are you good with this event changes?
I’ll deal with this pr after #169 merged since there is some conflict. |
JayJay1024
reviewed
Jul 26, 2022
Option<BalanceOf<T, I>>, | ||
Option<(T::AccountId, BalanceOf<T, I>)>, | ||
(T::AccountId, BalanceOf<T, I>), | ||
BalanceOf<T, I>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it seems that only amount but no account information for to_confirm_relayer
?
I have done this in the #169 , Close this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.