-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
@hackfisher the docs is here https://github.com/darwinia-network/darwinia-common/blob/master/frame/support/src/lib.rs#L103-L107. and this message_id also used in mapping-token-factory at https://github.com/darwinia-network/darwinia-bridge-sol/blob/master/contracts/mapping-token/contracts/darwinia/DarwiniaMappingTokenFactory.sol#L154 |
Since this is only used in wormhole and token protocol, please rename it to TokenMessageId or TokenBridgeMessageId, and also related traits & methods.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure whether we need to update the types.json for pangolin and pangoro.
The types.json is updated in |
Yes, there is no need to update for pangoro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. A question feedback left.
@@ -186,7 +186,7 @@ | |||
"Erc20": "TokenInfo" | |||
} | |||
}, | |||
"BridgeMessageId": "[u8; 16; BridgeMessageId]", | |||
"TokenMessageId": "[u8; 16; TokenMessageId]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious about this writing style, Can we change it to "TokenMessageId": "[u8; 16]",
?
To avoid the type conflict of this update.
paritytech/parity-bridges-common#1152