Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jk/finaltouches #75

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Jk/finaltouches #75

merged 2 commits into from
Sep 1, 2020

Conversation

jakeane
Copy link
Contributor

@jakeane jakeane commented Sep 1, 2020

Title

Change sidebar in home to display list instead of empty tabs. Also show current file in editor

  • Remove tabs from home
  • Implemented list items
  • Cleaned up excess code
  • Current file (or log) is highlighted in sidebar

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update

Screenshots/Screen Recordings

Home page

Screen Shot 2020-09-01 at 1 41 23 PM

Editor page

Screen Shot 2020-09-01 at 1 47 30 PM

@jakeane jakeane requested review from chriscsykes, valrw, arjunsrini, jcole13 and jeffzyliu and removed request for chriscsykes September 1, 2020 19:48
jeffzyliu
jeffzyliu approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jeffzyliu jeffzyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

chriscsykes
chriscsykes approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@chriscsykes chriscsykes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@jakeane jakeane merged commit a7e7c65 into master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscsykes chriscsykes chriscsykes approved these changes

@jeffzyliu jeffzyliu jeffzyliu approved these changes

@valrw valrw Awaiting requested review from valrw

@arjunsrini arjunsrini Awaiting requested review from arjunsrini

@jcole13 jcole13 Awaiting requested review from jcole13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakeane @jeffzyliu @chriscsykes