Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort tutorials and landing page behavior #70

Merged
merged 1 commit into from
Sep 1, 2020
Merged

sort tutorials and landing page behavior #70

merged 1 commit into from
Sep 1, 2020

Conversation

jakeane
Copy link
Contributor

@jakeane jakeane commented Sep 1, 2020

Title

Resolve sorting of tutorial files and provide solution for landing page

  • Modify sort() function using str.localeCompare() to account for numbers
  • Use @media in CSS to modify landing page layout on narrow page widths

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update

Screenshots/Screen Recordings

Screen Shot 2020-09-01 at 12 49 21 AM

jeffzyliu
jeffzyliu approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jeffzyliu jeffzyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight fire

valrw
valrw approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@valrw valrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@jeffzyliu jeffzyliu merged commit 52169c1 into master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valrw valrw valrw approved these changes

@jeffzyliu jeffzyliu jeffzyliu approved these changes

@jcole13 jcole13 Awaiting requested review from jcole13

@arjunsrini arjunsrini Awaiting requested review from arjunsrini

@chriscsykes chriscsykes Awaiting requested review from chriscsykes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakeane @jeffzyliu @valrw