Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 200 commits into
base: feedback
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
200 commits
Select commit Hold shift + click to select a range
c119ede
Setting up GitHub Classroom Feedback
timofei7 Aug 6, 2020
5b8de32
add img
jeffzyliu Aug 6, 2020
7db8b16
Merge pull request #2 from dartmouth-cs52-20X/uploadimage
arjunsrini Aug 6, 2020
3c6fceb
Update README.md
arjunsrini Aug 6, 2020
bd9b789
Update README.md
arjunsrini Aug 9, 2020
0ea3480
Add stata-commands gif
arjunsrini Aug 9, 2020
cf2baa1
Add higher-resolution stata-commands gif
arjunsrini Aug 9, 2020
2726aae
hello world frontend
Aug 11, 2020
19a62e4
Merge pull request #4 from dartmouth-cs52-20X/jk/boilerplate
valrw Aug 11, 2020
52e2374
Updated README
chriscsykes Aug 13, 2020
39580f5
Merge pull request #5 from dartmouth-cs52-20X/chriscsykes-readme
chriscsykes Aug 13, 2020
bba9b25
Update README.md
arjunsrini Aug 14, 2020
150d859
add an experimental regression-only single line parser and a driver n…
jeffzyliu Aug 14, 2020
8e351b6
rename files
jeffzyliu Aug 14, 2020
443732e
actually renamed files
jeffzyliu Aug 14, 2020
215ec91
moving files to a better directory structure, add example
jeffzyliu Aug 14, 2020
2be4240
add comments to example
jeffzyliu Aug 14, 2020
39d51a5
add (final?) architecture
jeffzyliu Aug 14, 2020
ed0f5aa
connect to backend
Aug 14, 2020
139a806
Merge pull request #6 from dartmouth-cs52-20X/jl/parser-testing
jakeane Aug 14, 2020
1ace2af
Merge pull request #7 from dartmouth-cs52-20X/jl/readme-1
arjunsrini Aug 14, 2020
0d63f21
Merge pull request #8 from dartmouth-cs52-20X/jk/api_connect
jcole13 Aug 14, 2020
ffa9d54
Update README.md
arjunsrini Aug 14, 2020
057e359
Merge pull request #9 from dartmouth-cs52-20X/arjunsrini-readme-update-1
arjunsrini Aug 15, 2020
590419c
Travis CI Config
chriscsykes Aug 17, 2020
af4ae57
updated package.json and .travis.yml
chriscsykes Aug 18, 2020
6e4ec72
changed package.json
chriscsykes Aug 18, 2020
caec341
set up surge with travis
valrw Aug 18, 2020
8efdf8f
Merge pull request #11 from dartmouth-cs52-20X/cs/add-travis
jakeane Aug 18, 2020
5e017fb
add pages and respective routes
Aug 18, 2020
02fb29d
changed .travis.yml to provided
valrw Aug 18, 2020
f3e905f
Merge pull request #13 from dartmouth-cs52-20X/jk/makepages
jeffzyliu Aug 18, 2020
21cf185
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
valrw Aug 18, 2020
7012453
Merge pull request #12 from dartmouth-cs52-20X/vw/surge-travis
valrw Aug 18, 2020
60c9b16
basic functionality of tutorials and projects page
chriscsykes Aug 19, 2020
c75fc46
signin/signup are now modals
valrw Aug 19, 2020
88c8119
add editor and api call
Aug 19, 2020
e7465c5
Merge pull request #22 from dartmouth-cs52-20X/cs/tutorials-projects-…
jakeane Aug 19, 2020
51edcc5
Merge pull request #23 from dartmouth-cs52-20X/vw/signin-signup
jakeane Aug 19, 2020
4c6fe57
Merge branch 'master' into jk/buildeditor
jakeane Aug 19, 2020
5af0dfd
Merge pull request #24 from dartmouth-cs52-20X/jk/buildeditor
jakeane Aug 19, 2020
a27bfca
remove old parser stuff
jeffzyliu Aug 19, 2020
1336e40
edit readme
jeffzyliu Aug 19, 2020
4f3c0a5
update .travis.yml
valrw Aug 19, 2020
0a91676
Merge pull request #25 from dartmouth-cs52-20X/vw/travis-update
jakeane Aug 20, 2020
f8aa8c0
build basic editor layout
Aug 23, 2020
8c60e3d
add general navbar
Aug 23, 2020
48c388a
cleaned up a bit. still having trouble with conditional rendering for…
chriscsykes Aug 23, 2020
5c47a16
update
chriscsykes Aug 23, 2020
070def2
update
chriscsykes Aug 23, 2020
12b8d44
changed structure of json
chriscsykes Aug 23, 2020
5bbcb3f
Merge pull request #28 from dartmouth-cs52-20X/jk/buildeditor
chriscsykes Aug 23, 2020
b21fd2a
fixed merge conflict
chriscsykes Aug 23, 2020
3bd5eca
added basic auth functionality
valrw Aug 24, 2020
d6940c7
missed a change
valrw Aug 24, 2020
3e95251
Merge pull request #29 from dartmouth-cs52-20X/vw/frontend-auth
chriscsykes Aug 24, 2020
7221570
able to get proper module, but not able to access it
chriscsykes Aug 24, 2020
f2f4e8b
latest
chriscsykes Aug 24, 2020
17d998f
comments
chriscsykes Aug 24, 2020
d55ca71
finish editor
Aug 24, 2020
69d622b
Merge branch 'master' into jk/buildeditor
jakeane Aug 24, 2020
f042fc3
fix merge issues
Aug 24, 2020
463ca68
fix merge issues
Aug 24, 2020
4838957
Merge pull request #31 from dartmouth-cs52-20X/jk/buildeditor
jakeane Aug 24, 2020
d5efd0f
set up home page
Aug 24, 2020
daf42c0
Merge pull request #32 from dartmouth-cs52-20X/jk/setupauth
jakeane Aug 24, 2020
7fb146a
history.push to homepage after signin/signup works
valrw Aug 25, 2020
5bb9248
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
valrw Aug 25, 2020
2fe9232
logout button in navbar works
valrw Aug 25, 2020
8ce172e
home and editor pages protected
valrw Aug 25, 2020
7f6a183
latest
chriscsykes Aug 25, 2020
f59f063
latest. tried to add key but not working
chriscsykes Aug 25, 2020
794b400
merge conflict
chriscsykes Aug 25, 2020
5c64970
latest. navbar included.
chriscsykes Aug 25, 2020
598b438
Merge branch 'cs/tutorials-projects-page' of https://github.com/dartm…
chriscsykes Aug 25, 2020
e185b78
fixed merge issues
chriscsykes Aug 25, 2020
c671442
Merge pull request #33 from dartmouth-cs52-20X/vw/frontend-auth
chriscsykes Aug 25, 2020
15a4f93
add actions and reducers
Aug 25, 2020
6c9ecd0
Merge branch 'master' into cs/tutorials-projects-page
chriscsykes Aug 25, 2020
76a5d84
Merge pull request #34 from dartmouth-cs52-20X/jk/setupauth
jakeane Aug 25, 2020
aaed4f4
Merge pull request #35 from dartmouth-cs52-20X/cs/tutorials-projects-…
jakeane Aug 25, 2020
744ede9
implement some of the basic endpoints
Aug 25, 2020
d4ffa23
Merge pull request #36 from dartmouth-cs52-20X/jk/basicendpoints
chriscsykes Aug 25, 2020
02c9d7f
finally working properly
chriscsykes Aug 25, 2020
c6a63a1
Merge branch 'cs/tutorials-projects-page' of https://github.com/dartm…
chriscsykes Aug 25, 2020
25805a8
working
chriscsykes Aug 25, 2020
c542ac6
Merge pull request #37 from dartmouth-cs52-20X/cs/tutorials-projects-…
jakeane Aug 26, 2020
5cb9afd
handle compiled code
Aug 26, 2020
2e275b7
flex wrap do file buttons
valrw Aug 26, 2020
7c02b7c
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
valrw Aug 26, 2020
7b26639
minor tweaks
Aug 26, 2020
dbc8bc7
switch from surge to netlify
valrw Aug 26, 2020
09d4eac
Merge pull request #39 from dartmouth-cs52-20X/vw/netlify
valrw Aug 26, 2020
f3019c7
add compilation and dofile navigation
Aug 26, 2020
9a7caaa
Merge pull request #40 from dartmouth-cs52-20X/jk/compilation
jakeane Aug 26, 2020
6f32818
welcome page shows editor link if authenticated
valrw Aug 26, 2020
19cba1f
create do file navigates to do file
Aug 26, 2020
d28b6bd
Merge pull request #42 from dartmouth-cs52-20X/jk/createbehavior
valrw Aug 26, 2020
2c5bad1
add adjustments from bug hunt
Aug 27, 2020
b93dfcf
Merge pull request #43 from dartmouth-cs52-20X/jk/postbughunt
jakeane Aug 27, 2020
bacad92
Merge pull request #41 from dartmouth-cs52-20X/vw/welcome-edits
valrw Aug 28, 2020
dec7fa4
fixed home page sidebar width to match logo
chriscsykes Aug 28, 2020
e1ac4b0
basic ui done
chriscsykes Aug 28, 2020
d573371
added alias input
chriscsykes Aug 28, 2020
26fa8b0
renaming dofiles implemented
valrw Aug 29, 2020
e4c22c7
should be working
chriscsykes Aug 29, 2020
0da9be9
added alert on successful upload
chriscsykes Aug 29, 2020
3bc39fd
Merge pull request #46 from dartmouth-cs52-20X/cs/file-widget
jakeane Aug 29, 2020
7915281
Merge pull request #45 from dartmouth-cs52-20X/vw/rename-dofile
jakeane Aug 29, 2020
f2af40d
add stuff
Aug 29, 2020
dd80da8
fix editfilename behavior
Aug 29, 2020
0457849
Merge branch 'master' into jk/editorbar
jakeane Aug 29, 2020
dc0903e
pre PR
Aug 29, 2020
ba2622e
Merge branch 'jk/editorbar' of https://github.com/dartmouth-cs52-20X/…
Aug 29, 2020
4e490ba
merge conflicts resolve
Aug 29, 2020
d228e2d
Merge pull request #48 from dartmouth-cs52-20X/jk/editorbar
jakeane Aug 29, 2020
2168d90
add submenus in sidebar
Aug 30, 2020
05801a7
Merge pull request #49 from dartmouth-cs52-20X/jk/handlelogs
jakeane Aug 30, 2020
b0e8221
added loading animations
chriscsykes Aug 30, 2020
41eb1bf
refactor tutorial options
Aug 30, 2020
f5134f5
added animations to refactored code, and broke some code off into the…
chriscsykes Aug 30, 2020
95b4286
added file size validation
chriscsykes Aug 30, 2020
41ef3dc
Merge pull request #51 from dartmouth-cs52-20X/cs/file-widget
chriscsykes Aug 30, 2020
4a0c486
adjust compile api call
Aug 30, 2020
1f3e909
Merge branch 'master' into jk/polishhome
jakeane Aug 30, 2020
c4a0ec8
Merge pull request #52 from dartmouth-cs52-20X/jk/polishhome
jakeane Aug 30, 2020
24dd2fc
add profile page content
valrw Aug 30, 2020
14c40dd
fix merge conflict
valrw Aug 30, 2020
0a45959
Update README.md
arjunsrini Aug 30, 2020
bf19dc7
Update README.md
arjunsrini Aug 30, 2020
238bfce
restyled site and added submenus to editor
Aug 30, 2020
ff81cc3
profile page, can change password
valrw Aug 30, 2020
7476052
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
valrw Aug 30, 2020
2c6d829
Merge branch 'master' into jk/polishhome
jakeane Aug 30, 2020
910d745
Merge pull request #53 from dartmouth-cs52-20X/jk/polishhome
jakeane Aug 30, 2020
71816d4
Merge branch 'master' into vw/profile
valrw Aug 30, 2020
fb232c1
Merge pull request #54 from dartmouth-cs52-20X/vw/profile
valrw Aug 30, 2020
b760ba5
Update README.md
jeffzyliu Aug 30, 2020
c12ced1
add icon and logfile behavior
Aug 30, 2020
24ab143
add mui alerts for uploading
Aug 31, 2020
b280b72
made sidebar lists more compact
Aug 31, 2020
437d1a9
adjust navbar filename behavior for logfiles
Aug 31, 2020
f38c5d1
Merge pull request #55 from dartmouth-cs52-20X/jk/logfiles
jakeane Aug 31, 2020
2e52329
updated widget to clear input
chriscsykes Aug 31, 2020
17d789b
some styling
valrw Aug 31, 2020
bafbd30
Merge pull request #57 from dartmouth-cs52-20X/cs/widget
jakeane Aug 31, 2020
5e57df0
Merge pull request #56 from dartmouth-cs52-20X/vw/styling
arjunsrini Aug 31, 2020
9722414
restyled landing page
arjunsrini Aug 31, 2020
df34a45
change title font back to normal
arjunsrini Aug 31, 2020
94d2fff
Merge pull request #58 from dartmouth-cs52-20X/landing-page-new
arjunsrini Aug 31, 2020
08e7c67
fixes to landing page and navbar
valrw Aug 31, 2020
00a33a1
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
valrw Aug 31, 2020
e0eaf3e
Update signin.js
valrw Aug 31, 2020
2ed8a85
Update signup.js
valrw Aug 31, 2020
420de3f
Update welcome.js
valrw Aug 31, 2020
e663fa9
Merge pull request #59 from dartmouth-cs52-20X/vw/styling
jeffzyliu Aug 31, 2020
bf3841b
thought i committed these
valrw Aug 31, 2020
9d72ceb
Merge branch 'vw/styling' of github.com:dartmouth-cs52-20X/project-op…
valrw Aug 31, 2020
32cdd71
Merge pull request #65 from dartmouth-cs52-20X/vw/styling
jeffzyliu Aug 31, 2020
5db5b10
typing title, buttons
jcole13 Aug 31, 2020
71b3ef0
styling fix
jcole13 Sep 1, 2020
01617f5
get and display tutorial files
valrw Sep 1, 2020
9313087
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
valrw Sep 1, 2020
3961626
Merge pull request #67 from dartmouth-cs52-20X/vw/styling
arjunsrini Sep 1, 2020
64802bc
Merge branch 'master' of github.com:dartmouth-cs52-20X/project-open-s…
jcole13 Sep 1, 2020
01c812f
capital title
jcole13 Sep 1, 2020
6e5ec2e
Merge pull request #68 from dartmouth-cs52-20X/jc/design
jcole13 Sep 1, 2020
64b4a9f
fix do files in side bar
valrw Sep 1, 2020
73233d9
fix do files in side bar
valrw Sep 1, 2020
b59112c
Merge pull request #69 from dartmouth-cs52-20X/vw/debug
jeffzyliu Sep 1, 2020
14b9598
sort tutorials and landing page behavior
Sep 1, 2020
52169c1
Merge pull request #70 from dartmouth-cs52-20X/jk/finaltouches
jeffzyliu Sep 1, 2020
4b54364
add tutorial sidebar modification
Sep 1, 2020
a790305
render sidebar when sidebar data determined
Sep 1, 2020
21a8118
styling
jcole13 Sep 1, 2020
685b565
Merge pull request #72 from dartmouth-cs52-20X/jc/design
jeffzyliu Sep 1, 2020
7441264
Update codeEditor.js
jakeane Sep 1, 2020
38973ae
additional tutorial rendering conditionals
Sep 1, 2020
832d8ff
Merge branch 'jk/finaltouches' of https://github.com/dartmouth-cs52-2…
Sep 1, 2020
960cd94
Merge pull request #71 from dartmouth-cs52-20X/jk/finaltouches
jakeane Sep 1, 2020
ef97e1b
fix enter key for signin/signup
Sep 1, 2020
29cef8d
Merge pull request #73 from dartmouth-cs52-20X/jk/finaltouches
jakeane Sep 1, 2020
14b7b51
add enter to signup username
Sep 1, 2020
3ba1b5d
prevent editing title in tutorials
Sep 1, 2020
6531fb8
update logfiles after run
Sep 1, 2020
e481044
update data sidebar after upload
Sep 1, 2020
67e8739
Merge pull request #74 from dartmouth-cs52-20X/jk/finaltouches
jakeane Sep 1, 2020
08e026c
change home buttons from tabs to list
Sep 1, 2020
33a6293
show current file in editor
Sep 1, 2020
4c40ec7
file validation working
chriscsykes Sep 1, 2020
e76f833
added input validation to not allow white spaces in alias
chriscsykes Sep 1, 2020
2de26ef
added comments
chriscsykes Sep 1, 2020
bbd1377
Merge pull request #76 from dartmouth-cs52-20X/cs/file-validation
jeffzyliu Sep 1, 2020
a7e7c65
Merge pull request #75 from dartmouth-cs52-20X/jk/finaltouches
jakeane Sep 1, 2020
7b275c2
change icons in editor
Sep 1, 2020
e67dc35
Merge pull request #77 from dartmouth-cs52-20X/jk/finaltouches
jeffzyliu Sep 1, 2020
c74dfc3
docs button
jcole13 Sep 1, 2020
c9743bc
Merge pull request #78 from dartmouth-cs52-20X/jc/design
jakeane Sep 1, 2020
27f61e6
update README with gifs
jeffzyliu Sep 2, 2020
b921de2
Update README.md
jakeane Sep 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added input validation to not allow white spaces in alias
chriscsykes committed Sep 1, 2020
commit e76f833b49f8f68ed2ef53d6173d805091abd5f7
10 changes: 7 additions & 3 deletions src/pages/codeEditor.js
Original file line number Diff line number Diff line change
@@ -239,7 +239,9 @@ Statistics/Data Analysis`;

// handles the situation where we are uploading by file
const handleFileUpload = () => {
if (fileToUpload && alias) {
if (alias.indexOf(' ') >= 0) {
handleAlert('error: Alias must not contain any white space characters', 'error');
} else if (fileToUpload && alias) {
setUploading(true);
uploadFile(fileToUpload)
.then((url) => {
@@ -265,8 +267,10 @@ Statistics/Data Analysis`;

// handles the situation where we are uploading by URL
const handleURLUpload = () => {
// directly save the non-s3 url and alias to endpoint Jeff is creating
if (urlToUpload && alias) {
if (alias.indexOf(' ') >= 0) {
handleAlert('error: Alias must not contain any white space characters', 'error');
} else if (urlToUpload && alias) {
// directly save the non-s3 url and alias to endpoint Jeff is creating
setUploading(true);
const post = {
fileName: alias,