Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong line endings used when building YAML edits #1939

Closed
DanTup opened this issue Feb 16, 2024 · 0 comments · Fixed by dart-lang/yaml_edit#66
Closed

Wrong line endings used when building YAML edits #1939

DanTup opened this issue Feb 16, 2024 · 0 comments · Fixed by dart-lang/yaml_edit#66
Labels
package:yaml_edit

Comments

@DanTup
Copy link
Contributor

DanTup commented Feb 16, 2024 •
edited
Loading

Trying to track down some failing tests on Windows in the analysis server, and it seems to be caused by this:

https://github.com/dart-lang/yaml_edit/blob/2a9a11bee120d507d61d501c34585440be8c12b6/lib/src/strings.dart#L277

It's using \n but never gets rewritten to lineEnding, so the resulting YAML has a mix of \n and \r\n on Windows.
DanTup referenced this issue in DanTup/yaml_edit Feb 20, 2024
@DanTup
Fix line endings for inserted maps on Windows
7ed8618 
Fixes https://github.com/dart-lang/yaml_edit/issues/65
@DanTup DanTup mentioned this issue Feb 20, 2024
Merged
DanTup referenced this issue in DanTup/yaml_edit Feb 20, 2024
@DanTup
Fix line endings for inserted maps on Windows
ff93da8 
Fixes https://github.com/dart-lang/yaml_edit/issues/65
kevmoo referenced this issue in dart-lang/yaml_edit Feb 21, 2024
@DanTup
Fix line endings for inserted maps on Windows (#66)
82ab64d 
Fixes https://github.com/dart-lang/yaml_edit/issues/65
mosuem referenced this issue Dec 11, 2024
@DanTup
Fix line endings for inserted maps on Windows (dart-lang/yaml_edit#66)
5e7e143 
Fixes https://github.com/dart-lang/yaml_edit/issues/65
@mosuem mosuem transferred this issue from dart-lang/yaml_edit Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:yaml_edit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix line endings for inserted maps on Windows DanTup/yaml_edit
2 participants
@DanTup @mosuem