Implement the VM service getFlagList API
#2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helin24
approved these changes
May 28, 2024
DanTup
approved these changes
May 29, 2024
| bool _pauseIsolatesOnStart = false; | ||
| /// The flags that can be set at runtime via [setFlag]. | ||
| final Map<String, bool> _supportedVmServiceFlags = { | ||
| _pauseIsolatesOnStartFlag: false, |
There was a problem hiding this comment.
Is pause-on-exit not supported?
There was a problem hiding this comment.
pause-on-exit is not supported - because the web doesn't have "real" isolates we mimic the pause-on-start behavior by waiting to run the app's main method until we get a resume event. However, I can't think of a way we could mimic pause-on-exit.
| @@ -92,12 +92,16 @@ class ChromeProxyService implements VmServiceInterface { | |||
|
|
|||
| StreamSubscription<ConsoleAPIEvent>? _consoleSubscription; | |||
|
|
|||
| bool _pauseIsolatesOnStart = false; | |||
| /// The flags that can be set at runtime via [setFlag]. | |||
| final Map<String, bool> _supportedVmServiceFlags = { | |||
There was a problem hiding this comment.
Is the name of this map a bit misleading now? It sounds like a set of supported flags, but based on the comment and code below, it appears to be holding the actual flag values now too. (_currentVmServiceFlags or something?)
There was a problem hiding this comment.
Good point, changed to _currentVmServiceFlags!
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#55859
FYI @DanTup