Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE server common: move from pkg:usage to pkg:uuid #2412

Merged
merged 1 commit into from
Apr 18, 2024
Merged

FE server common: move from pkg:usage to pkg:uuid #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend_server_common/lib/src/frontend_server_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import 'package:dwds/expression_compiler.dart';
import 'package:logging/logging.dart';
import 'package:package_config/package_config.dart';
import 'package:test_common/test_sdk_layout.dart';
import 'package:usage/uuid/uuid.dart';
import 'package:uuid/uuid.dart';

import 'utilities.dart';

Expand Down Expand Up @@ -320,7 +320,7 @@ class ResidentCompiler {
}
var server = _server!;

var inputKey = Uuid().generateV4();
var inputKey = const Uuid().v4();
server.stdin.writeln('recompile $mainUri$inputKey');
_logger.info('<- recompile $mainUri$inputKey');
for (var fileUri in request.invalidatedFiles) {
Expand Down Expand Up @@ -463,7 +463,7 @@ class ResidentCompiler {
}
var server = _server!;

var inputKey = Uuid().generateV4();
var inputKey = const Uuid().v4();
server.stdin.writeln('compile-expression $inputKey');
server.stdin.writeln(request.expression);
request.definitions.forEach(server.stdin.writeln);
Expand Down Expand Up @@ -508,7 +508,7 @@ class ResidentCompiler {
}
var server = _server!;

var inputKey = Uuid().generateV4();
var inputKey = const Uuid().v4();
server.stdin.writeln('compile-expression-to-js $inputKey');
server.stdin.writeln(request.libraryUri);
server.stdin.writeln(request.line);
Expand Down
2 changes: 1 addition & 1 deletion frontend_server_common/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ dependencies:
pub_semver: ^2.1.1
test_common:
path: ../test_common
usage: ^4.0.0
uuid: ^3.0.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that uuid is not currently dep'd into the sdk rep. We have - in one other location - chosen to in-line a uuid v4 implementation (but I don't currently re-call where).

uuid itself may be harmless to bring into the sdk; we do generally try to limit deps there (or, to be conservative about bring in new ones).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could just copy-paste. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2415

Loading