Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FrontendServerClient start the frontend server from AOT snapshot by default #2263

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Make FrontendServerClient start the frontend server from AOT snapshot by default #2263

merged 5 commits into from
Jan 8, 2024

Conversation

derekxu16
Copy link
Member

No description provided.

@derekxu16 derekxu16 requested a review from jakemac53 October 24, 2023 17:45
@derekxu16
Copy link
Member Author

Making this change as part of dart-lang/sdk#53576. Please let me know if you have any concerns.

@derekxu16 derekxu16 marked this pull request as ready for review October 24, 2023 17:49
@derekxu16 derekxu16 force-pushed the use-frontend-server-aot-snapshot branch from 19c0821 to 7cc3c8b Compare October 24, 2023 21:57
@jakemac53
Copy link
Contributor

@elliette @annagrin did one of you want to review this or do you want me to?

@elliette
Copy link
Contributor

@elliette @annagrin did one of you want to review this or do you want me to?

Very happy to have you review, thanks! FrontendServerClient is still a blackbox to me.

@annagrin
Copy link
Contributor

annagrin commented Nov 1, 2023

@elliette @annagrin did one of you want to review this or do you want me to?

Please review!

@annagrin
Copy link
Contributor

annagrin commented Nov 1, 2023

Making this change as part of dart-lang/sdk#53576. Please let me know if you have any concerns.

Could you please add a description of the change in the packages' changelog.md (with reference to this PR) - you can see examples in dwds's changelog.

@jakemac53 jakemac53 mentioned this pull request Nov 6, 2023
Open
@derekxu16 derekxu16 force-pushed the use-frontend-server-aot-snapshot branch from 7ff5b0a to 0fe4b74 Compare November 13, 2023 19:16
@derekxu16
Copy link
Member Author

Please let me know if these changes look ok. If they do, then we'll need to decide whether to publish package:frontend_server_client v3.3.0 or defer the changes in v3.3.0-wip to v4.0.0. I'll also need to update package:test_core to accept package:frontend_server_client v4.0.0 to make CI checks pass on this PR. That will be safe to do as package:test_core never sets the debug argument of FrontendServerClient.start to true.

jakemac53
jakemac53 reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally LGTM, @annagrin did we want to publish 3.3.0 first?

frontend_server_client/lib/src/frontend_server_client.dart Outdated Show resolved Hide resolved
frontend_server_client/lib/src/frontend_server_client.dart Show resolved Hide resolved
frontend_server_client/lib/src/frontend_server_client.dart Outdated Show resolved Hide resolved
frontend_server_client/lib/src/frontend_server_client.dart Outdated Show resolved Hide resolved
@derekxu16
Copy link
Member Author

friendly ping @annagrin

@annagrin
Copy link
Contributor

annagrin commented Dec 7, 2023

LGTM!

annagrin
annagrin approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekxu16 derekxu16 force-pushed the use-frontend-server-aot-snapshot branch 4 times, most recently from 0174cd2 to 638a669 Compare December 14, 2023 19:58
@derekxu16 derekxu16 force-pushed the use-frontend-server-aot-snapshot branch 3 times, most recently from 7ae2041 to bd531dd Compare December 19, 2023 15:27
@derekxu16 derekxu16 force-pushed the use-frontend-server-aot-snapshot branch from bd531dd to 2ed81fd Compare December 19, 2023 15:37
@derekxu16 derekxu16 force-pushed the use-frontend-server-aot-snapshot branch from 2ed81fd to 1c7c9f1 Compare December 19, 2023 15:38
@derekxu16 derekxu16 merged commit 651bdae into dart-lang:master Jan 8, 2024
47 checks passed
@derekxu16 derekxu16 deleted the use-frontend-server-aot-snapshot branch January 8, 2024 18:18
@derekxu16 derekxu16 mentioned this pull request Jan 8, 2024
Open
13 tasks
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 9, 2024
@devoncarew
[deps] rev async, ecosystem, leak_tracker, markdown, native, protobuf…
0b5f092 
…, shelf, tools, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/9924570..e83d054):
  e83d054  2024-01-08  Futuristic Goo  Fix typo (dart-archive/async#262)

ecosystem (https://github.com/dart-lang/ecosystem/compare/dc44e82..1e2785d):
  1e2785d  2024-01-09  Jacob MacDonald  fix saving of comment ids to disk (dart-lang/ecosystem#221)
  244a28d  2024-01-09  Moritz  Update publish.yaml (dart-lang/ecosystem#217)
  bab9833  2024-01-09  Moritz  Fix health commenting (dart-lang/ecosystem#219)
  f87e6f4  2024-01-08  Moritz  Update health workflow (dart-lang/ecosystem#216)
  a58c7d8  2024-01-03  Moritz  Fix `labeler.yml` (dart-lang/ecosystem#214)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/3d4c0d6..4a5b077):
  4a5b077  2024-01-09  Polina Cherkasova  Enhance scripting. (dart-lang/leak_tracker#204)
  e7094f4  2024-01-08  Polina Cherkasova  Ignore test helpers. (dart-lang/leak_tracker#196)
  6591934  2024-01-03  Polina Cherkasova  Handle deprecation in Flutter. (dart-lang/leak_tracker#203)

markdown (https://github.com/dart-lang/markdown/compare/d2e7903..7fdfa55):
  7fdfa55  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (dart-lang/markdown#571)
  5fab3a7  2023-12-19  Alex Li  ✨ Introduce AlertBlockSyntax (dart-lang/markdown#570)

native (https://github.com/dart-lang/native/compare/0605d9a..14f6da1):
  14f6da1d  2024-01-09  Simon Binder  Support `@Native` fields and `addressOf` (dart-lang/native#860)

protobuf (https://github.com/dart-lang/protobuf/compare/20ec685..a293fb9):
  a293fb9  2024-01-08  Ömer Sinan Ağacan  Handle deprecated options in grpc services and methods, enum types and values, messages (google/protobuf.dart#908)
  9a408a7  2024-01-08  Ömer Sinan Ağacan  Generate docs of enums and rpc clients, some refactoring (google/protobuf.dart#909)
  c4fd596  2024-01-06  Ömer Sinan Ağacan  Export GeneratedMessageGenericExtensions in generated files (google/protobuf.dart#907)

shelf (https://github.com/dart-lang/shelf/compare/733588f..823966f):
  823966f  2024-01-03  Moritz  Fix `labeler.yml` (dart-lang/shelf#403)

tools (https://github.com/dart-lang/tools/compare/2f59ab4..8ffc077):
  8ffc077  2024-01-03  Moritz  Fix `labeler.yml` (dart-lang/tools#224)

webdev (https://github.com/dart-lang/webdev/compare/b2405cb..c08a65c):
  c08a65c9  2024-01-09  Elliott Brooks  Loosen `vm_service` constraints and prepare DWDS for release to 23.1.1 (dart-lang/webdev#2329)
  651bdae6  2024-01-08  Derek Xu  Make FrontendServerClient start the frontend server from AOT snapshot by default (dart-lang/webdev#2263)
  4d1de266  2024-01-03  Elliott Brooks  Prepare DWDS for release to version 23.1.0 (dart-lang/webdev#2328)

Change-Id: I4d7fd994cc54ac2d72335c3ebf40710f3bd020e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345366
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
@derekxu16 derekxu16 mentioned this pull request Mar 28, 2024
Merged
@elliette elliette mentioned this pull request Apr 3, 2024
Closed
This was referenced Apr 6, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-siva a-siva a-siva left review comments

@annagrin annagrin annagrin approved these changes

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
package:frontend_server_client run-dcm-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derekxu16 @jakemac53 @elliette @annagrin @a-siva