Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK constraint everywhere #1816

Closed
wants to merge 7 commits into from

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Dec 8, 2022

No description provided.

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevmoo
Copy link
Member

kevmoo commented Dec 9, 2022

Is this required? I thought everything was opted-in to v3 by default?

CC @mit-mit @devoncarew

@mit-mit
Copy link
Member

mit-mit commented Dec 9, 2022

No, this is not required, see the 'Backwards compatibility for null safe packages' section in dart-lang/sdk#49530

Given it's a no-op, I'd recommend not churning all our packages for it. I'd recommend changing the upper constraint to <4.0.0 when you get to the point when you are also changing the lower constraint to >=3.0.0.

@elliette
Copy link
Contributor Author

elliette commented Dec 9, 2022

No, this is not required, see the 'Backwards compatibility for null safe packages' section in dart-lang/sdk#49530

Given it's a no-op, I'd recommend not churning all our packages for it. I'd recommend changing the upper constraint to <4.0.0 when you get to the point when you are also changing the lower constraint to >=3.0.0.

Got it, thank you! Closing in favor of #1817 (still a WIP) to fix the tests that are failing at head.

@elliette elliette closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants