Validate build_web_compilers, Exception handling #16
Conversation
| onError: errorPort.sendPort, | ||
| automaticPackageResolution: true); | ||
| } on IsolateSpawnException { | ||
| exitPort.close(); |
There was a problem hiding this comment.
@natebosch – should do this on build_runner, too – ensures the process actually exits!
There was a problem hiding this comment.
hrm...or maybe this should be try/finally....
There was a problem hiding this comment.
try finally would maybe be better.
What is a case where IsoalteSpawnException would get raised?
If package:isolate abstracts any of this for us we should make it a priority to migrate - I don't like having this much duplication
webdev/CHANGELOG.md
Outdated
| ## 0.1.1 | ||
|
|
||
| - Checks for a dependency on `build_web_compilers`. | ||
|
|
There was a problem hiding this comment.
I still don't understand why some people like <li><p>stuff</p></li> instead of <li>stuff</li>...
| onError: errorPort.sendPort, | ||
| automaticPackageResolution: true); | ||
| } on IsolateSpawnException { | ||
| exitPort.close(); |
There was a problem hiding this comment.
try finally would maybe be better.
What is a case where IsoalteSpawnException would get raised?
If package:isolate abstracts any of this for us we should make it a priority to migrate - I don't like having this much duplication
|
@natebosch – added two more commits – while I was at it. PTAL |
| await process.shouldExit(78); | ||
| }); | ||
|
|
||
| test('should fail gracefully if there is an isolate error', () async { |
There was a problem hiding this comment.
where are we causing the isolate error?
There was a problem hiding this comment.
I synthesized one to make sure we "do the right thing".
For the script runner, I just use a bad .packages file.
For the main runner, I gave it a bad file to execute...
kevmoo
force-pushed
the
updates
branch
2 times, most recently
from
107e6d4
to
fd42c7b
Compare
No description provided.