Collect log message count and log at the end (#2430)

dart-lang · May 14, 2024 · fc32eb6 · fc32eb6
1 parent 99abc53
commit fc32eb6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/dwds/lib/src/debugging/debugger.dart b/dwds/lib/src/debugging/debugger.dart
@@ -54,6 +54,8 @@ class Debugger extends Domain {
   final Locations _locations;
   final SkipLists _skipLists;
 
+  int _frameErrorCount = 0;
+
   Debugger._(
     this._remoteDebugger,
     this._streamNotify,
@@ -465,15 +467,23 @@ class Debugger extends Domain {
       try {
         dartFrame.vars = await variablesFor(frame);
       } catch (e) {
-        logger.warning(
-          'Error calculating Dart variables for frame $frameIndex: $e',
-        );
+        _frameErrorCount++;
       }
     }
 
     return dartFrame;
   }
 
+  /// Can be called after [calculateDartFrameFor] to log any errors.
+  void logAnyFrameErrors({required String frameType}) {
+    if (_frameErrorCount > 0) {
+      logger.warning(
+        'Error calculating Dart variables for $_frameErrorCount $frameType frames.',
+      );
+    }
+    _frameErrorCount = 0;
+  }
+
   void _scriptParsedHandler(ScriptParsedEvent e) {
     final scriptPath = _pathForChromeScript(e.script.url);
     if (scriptPath != null) {

diff --git a/dwds/lib/src/debugging/frame_computer.dart b/dwds/lib/src/debugging/frame_computer.dart
@@ -73,6 +73,7 @@ class FrameComputer {
         logger.warning('Error calculating sync frame: $e');
       }
     }
+    debugger.logAnyFrameErrors(frameType: 'sync');
   }
 
   Future<void> _collectAsyncFrames({int? limit}) async {
@@ -129,6 +130,7 @@ class FrameComputer {
             logger.warning('Error calculating async frame: $e');
           }
         }
+        debugger.logAnyFrameErrors(frameType: 'async');
       }
 
       // Async frames are no longer on the stack - we don't have local variable