Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have web.dart export the helpers; deprecate helpers.dart #115

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

devoncarew
Copy link
Member


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

This leaves us with:

  • web.dart
  • helpers.dart (deprecated)
  • src/dom.dart
  • src/helpers.dart

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

@devoncarew devoncarew merged commit 34b3618 into main Dec 5, 2023
11 checks passed
@devoncarew devoncarew deleted the web_helpers_refactor branch December 5, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not export web.dart from helpers.dart
2 participants