Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverage] VmService exception at exit on github CI #685

Closed
liamappelbe opened this issue Oct 23, 2024 · 1 comment · Fixed by #1189
Closed

[coverage] VmService exception at exit on github CI #685

liamappelbe opened this issue Oct 23, 2024 · 1 comment · Fixed by #1189
Assignees
@liamappelbe
Labels
package:coverage

Comments

@liamappelbe
Copy link
Contributor

liamappelbe commented Oct 23, 2024 •
edited
Loading

dart-lang/native#1676
https://github.com/dart-lang/native/actions/runs/11472010902/job/31924474755?pr=1676

The connection is being disposed early. Haven't been able to repro locally. I'll have to debug on CI.

I can add a check to the service.resume call, to make sure the service isn't disposed, but I'd like to understand the issue first, otherwise it could mask a bug.
@liamappelbe liamappelbe self-assigned this Oct 23, 2024
liamappelbe added a commit that referenced this issue Nov 7, 2024
@liamappelbe
Fix #685
a4ed4e9
@liamappelbe liamappelbe mentioned this issue Nov 7, 2024
Merged
@liamappelbe
Copy link
Contributor Author

The fix is in package:coverage v1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
package:coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[coverage] Fix isolate resumption after service disposal dart-lang/tools
1 participant
@liamappelbe