add analysis_options and pkg:pedantic lints #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Sep 11, 2018
natebosch
reviewed
Sep 11, 2018
| @@ -8,4 +8,5 @@ environment: | |||
| sdk: ">=2.0.0 <3.0.0" | |||
|
|
|||
| dev_dependencies: | |||
| pedantic: 1.1.0 | |||
There was a problem hiding this comment.
missed this earlier - should this be ^1.1.0 to accept new versions?
There was a problem hiding this comment.
Do we want to keep this locked hard so we don't have no lints sprung on us causing a break?
Is adding a lint considered breaking?
There was a problem hiding this comment.
IMO it should be treated along the lines of @deprecated. If package:pedantic is published with new lints our travis will go red until we address it, which is fine.
|
ack
…On Tue, Sep 11, 2018 at 2:17 PM Nate Bosch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pubspec.yaml
<#4 (comment)>:
> @@ -8,4 +8,5 @@ environment:
sdk: ">=2.0.0 <3.0.0"
dev_dependencies:
+ pedantic: 1.1.0
IMO it should be treated along the lines of @deprecated. If
package:pedantic is published with new lints our travis will go red until
we address it, which is fine.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABCimjqSprc8yp0sdM-IhsuXFx17cE0ks5uaChfgaJpZM4WkILf>
.
|
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.