Validate platform selectors against string sets #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to add platforms that extend existing platforms without running into serialization headaches. It also cleans up the Declarer API and means we're sending less redundant data between isolates.
grouma
approved these changes
Oct 10, 2017
| @@ -11,6 +11,7 @@ import 'test_platform.dart'; | |||
| /// The set of statically-known valid variable names. | |||
| final _validVariables = | |||
There was a problem hiding this comment.
I'm thinking we should change this variable name since we now pass a validVariables argument in validate. Maybe _staticValidVariables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add platforms that extend existing platforms
without running into serialization headaches. It also cleans up the
Declarer API and means we're sending less redundant data between
isolates.
See #391