Send test platforms to the remote listener #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
approved these changes
Oct 3, 2017
| @@ -192,8 +192,8 @@ class BrowserPlatform extends PlatformPlugin { | |||
| /// | |||
| /// This will start a browser to load the suite if one isn't already running. | |||
| /// Throws an [ArgumentError] if [browser] isn't a browser platform. | |||
| Future<RunnerSuite> load( | |||
| String path, TestPlatform browser, SuiteConfiguration suiteConfig) async { | |||
| Future<RunnerSuite> load(String path, TestPlatform browser, | |||
There was a problem hiding this comment.
I believe this will be breaking for Bolt internally. So again we'll have to be cautious with the next roll.
There was a problem hiding this comment.
Yeah, and there are more changes coming down that will slightly change the plugin API in other ways. It should all be straightforward to migrate, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the remote listener has access to any platforms that
are dynamically loaded in the test runner, so they can be used in
platform selectors.
See #99
See #391