Load Exception #682
Load Exception #682
Conversation
lib/dart.js
Outdated
| @@ -19,6 +19,11 @@ var sendLoadException = function(message) { | |||
| }, window.location.origin); | |||
| } | |||
|
|
|||
| // Listen for loadException events and forward to the server. | |||
| window.addEventListener('loadException', function(e) { | |||
There was a problem hiding this comment.
nit: consider something a bit more specific like dartTestLoadException or similar, since this is on the global window object you may run into conflicts
There was a problem hiding this comment.
Changed to dartLoadException given that this logic can reside outside of tests.
Dispatch load exception so that others can react without capturing the corresponding error. Will be used in conjunction with dart-lang/test#682 Bug: Change-Id: I19458ac01ba013cac6ad5408b3b763777e50ca4e Reviewed-on: https://dart-review.googlesource.com/6644 Reviewed-by: Jake Macdonald <[email protected]> Commit-Queue: Gary Roumanis <[email protected]>
| @@ -1,3 +1,7 @@ | |||
| ## 0.12.24+5 | |||
|
|
|||
| * Expose a way for tests to forward a `loadException` to the server. | |||
There was a problem hiding this comment.
If we're exposing a new feature, this should bump the minor version to 0.12.25. It should also describe how tests can forward load exceptions both here and in either the README or the API docs.
If it's not a user-visible feature, the CHANGELOG should just say "no user-visible changes".
There was a problem hiding this comment.
Noted. This is a non user-visible feature.
| @@ -19,6 +19,11 @@ var sendLoadException = function(message) { | |||
| }, window.location.origin); | |||
| } | |||
|
|
|||
| // Listen for dartLoadException events and forward to the server. | |||
| window.addEventListener('dartLoadException', function(e) { | |||
There was a problem hiding this comment.
Why do we have our own event type for this, as opposed to catching zone exceptions or handling global JS errors?
There was a problem hiding this comment.
Global JS errors can happen for a number of reasons and may not be indicative of an actual load exception. What we really want is if DDC failed to load. The above event is passed by the DDC's dart_library helper. See https://dart-review.googlesource.com/c/sdk/+/6644
There was a problem hiding this comment.
It would be good to add a comment indicating that dartLoadException is an exception produced by DDC in particular.
Exposing a way for tests to send a load exception to the test server. This will be used by DDC tests here: https://github.com/dart-lang/sdk/blob/0edc00171a9881d330b633cf0f43b0654e2653c1/pkg/dev_compiler/lib/js/legacy/dart_library.js#L16