Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use toFilePath in package config Uri #2262

Merged
merged 2 commits into from
Aug 12, 2024
Merged

fix: use toFilePath in package config Uri #2262

merged 2 commits into from
Aug 12, 2024

Conversation

Zekfad
Copy link
Contributor

@Zekfad Zekfad commented Aug 11, 2024

fixes #2231

Thanks to @d-markey #2231 (comment) for figuring it out.

This fix uses the same technique as in precompiled tests:

'--packages=${(await Isolate.packageConfig)!.toFilePath()}',


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@osa1 osa1 merged commit e656e5a into dart-lang:master Aug 12, 2024
37 checks passed
jakemac53 added a commit that referenced this pull request Aug 12, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 13, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/f977423..2719d0c):
  2719d0c  2024-08-08  Devon Carew  add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment (dart-lang/ecosystem#285)

http (https://github.com/dart-lang/http/compare/73fce77..76512c4):
  76512c4  2024-08-07  Kate  test(http_client_conformance_tests): Remove old skips (dart-lang/http#1284)
  d7ae256  2024-08-08  Anikate De  [docs] sort pkg list in ascending order (dart-lang/http#1287)
  b82d88c  2024-08-06  Anikate De  [docs] Add ok_http entry to readme (dart-lang/http#1285)

package_config (https://github.com/dart-lang/package_config/compare/f0b7256..76934c2):
  76934c2  2024-08-06  Kevin Moore  Latest lints, require Dart 3.4 (dart-lang/package_config#157)

sync_http (https://github.com/dart-lang/sync_http/compare/ab8377e..91c0dd5):
  91c0dd5  2024-08-12  dependabot[bot]  Bump actions/checkout from 4.1.6 to 4.1.7 (google/sync_http.dart#49)

test (https://github.com/dart-lang/test/compare/9fbbfdb..8be3c94):
  8be3c948  2024-08-12  Ömer Sinan Ağacan  Run dart2wasm integration test on Windows (dart-lang/test#2265)
  e656e5a9  2024-08-12  Yaroslav Vorobev  fix: use `toFilePath` in package config Uri (dart-lang/test#2262)
  6bfe0d62  2024-08-12  Ömer Sinan Ağacan  Fix documentation rendering issues (dart-lang/test#2264)

tools (https://github.com/dart-lang/tools/compare/55dbd6e..d563c38):
  d563c38  2024-08-13  Moritz  Add health workflow (dart-lang/tools#292)
  8ac5509  2024-08-12  Devon Carew  Update CODEOWNERS for package:unified_analytics (dart-lang/tools#289)

web (https://github.com/dart-lang/web/compare/e89fe49..4996dc2):
  4996dc2  2024-08-12  Srujan Gaddam  Ignore unintended_html_in_doc_comment (dart-lang/web#278)

Change-Id: I808778af5fb9a1f6885ae847614ffb660fcb8662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380204
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
jakemac53 added a commit that referenced this pull request Aug 13, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 19, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/ce09815..b444974):
  b4449742  2024-08-14  Sam Rawlins  Add a doc-import into template_data.dart to resolve 'GeneratorBackend.write' (dart-lang/dartdoc#3832)
  7fb1f3f3  2024-08-14  Sam Rawlins  Fix links in sidebar of extension types (dart-lang/dartdoc#3831)
  392e2aa3  2024-08-14  Sam Rawlins  Simplify some Container fields only used for sidebar logic. (dart-lang/dartdoc#3834)
  31e110d6  2024-08-13  Sam Rawlins  Add tests supporting the wildcard feature (dart-lang/dartdoc#3835)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2719d0c..8626bff):
  8626bff  2024-08-16  Jacob MacDonald  More concise formatting of github workflow summary comments (dart-lang/ecosystem#288)
  de7883c  2024-08-14  Moritz  Update PR Health install instructions (dart-lang/ecosystem#286)
  03bf029  2024-08-14  Moritz  Fix linting (dart-lang/ecosystem#287)

http (https://github.com/dart-lang/http/compare/76512c4..b97b8dc):
  b97b8dc  2024-08-16  Anikate De  pkgs/ok_http: OkHttpClientConfiguration and configurable timeouts. (dart-lang/http#1289)
  4322382  2024-08-13  Brian Quinlan  Fix "unintended_html_in_doc_comment" analysis errors (dart-lang/http#1291)

test (https://github.com/dart-lang/test/compare/8be3c94..cd3dbd5):
  cd3dbd51  2024-08-15  Jacob MacDonald  require approval from core-package-admins for anything under /pkgs (dart-lang/test#2268)
  cfc18ee1  2024-08-14  Jacob MacDonald  add health check job (dart-lang/test#2266)
  f3984a72  2024-08-13  Jacob MacDonald  update changelogs per dart-lang/test#2262 (dart-lang/test#2267)

tools (https://github.com/dart-lang/tools/compare/d563c38..5b15f8b):
  5b15f8b  2024-08-14  Nate Bosch  Add examples of calling two algorithms to README (dart-lang/tools#293)
  ece541c  2024-08-14  Nate Bosch  Ignore unintended_html_in_doc_comment (dart-lang/tools#294)

Change-Id: I23d2f9606e4bfefdfa61e0a4c629f3f05f00c996
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381320
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run wasm test on windows
2 participants