Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min SDK to 2.4.0 for bug in for-loop elements #1147

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Conversation

natebosch
Copy link
Member

Close #1141

Bump min SDK in all packages for safety. Restore use of for-loop
elements in a top level variable since they work in this SDK.

Close #1141

Bump min SDK in all packages for safety. Restore use of for-loop
elements in a top level variable since they work in this SDK.
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump mono_repo SDK versions, too!


* Bump minimum SDK to `2.4.0` for safer usage of for-loop elements.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

@natebosch natebosch merged commit 06f9f2f into master Jan 21, 2020
@natebosch natebosch deleted the dart-2-4 branch January 21, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_api: crashes w/ dart2js with latest deployment
4 participants