Forbid define_platforms in the global config file

dart-lang · Oct 16, 2017 · 465927c · 465927c
1 parent b1e8da7
commit 465927c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/src/runner/configuration/load.dart b/lib/src/runner/configuration/load.dart
@@ -238,6 +238,7 @@ class _ConfigurationLoader {
       _disallow("filename");
       _disallow("include_tags");
       _disallow("exclude_tags");
+      _disallow("define_platforms");
       return Configuration.empty;
     }
 

diff --git a/test/runner/configuration/global_test.dart b/test/runner/configuration/global_test.dart
@@ -94,9 +94,10 @@ void main() {
   group("disallows local-only configuration:", () {
     for (var field in [
       "skip", "retry", "test_on", "paths", "filename", "names", "tags", //
-      "plain_names", "include_tags", "exclude_tags", "pub_serve", "add_tags"
+      "plain_names", "include_tags", "exclude_tags", "pub_serve", "add_tags",
+      "define_platforms"
     ]) {
-      test("rejects local-only configuration", () async {
+      test("for $field", () async {
         await d.file("global_test.yaml", JSON.encode({field: null})).create();
 
         await d.file("test.dart", """