Add a SpanScanner.spanFromPosition() method
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Jul 9, 2024
|
Can you add a brief description of the use case to the first comment so I can include it in the commit message? |
Tracking raw ints can be more efficient than tracking `LineScannerState` objects, and allows users to do small manual manipulations on the resulting positions.
natebosch
approved these changes
Jul 9, 2024
Comment on lines
+100
to
+102
| /// Throws a [RangeError] if [startPosition] or [endPosition] aren't within | ||
| /// this source file. | ||
| FileSpan spanFromPosition(int startPosition, [int? endPosition]) => |
There was a problem hiding this comment.
Do we need to add the RangeError.checkValidRange call in this implementation?
There was a problem hiding this comment.
No, this one is handled automatically by SourceFile.
|
Thanks! I'll start getting this rolled so that we can publish. |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
…er#78) Tracking raw ints can be more efficient than tracking `LineScannerState` objects, and allows users to do small manual manipulations on the resulting positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking raw ints can be more efficient than tracking
LineScannerStateobjects, and allows users to do small manual manipulations on the resulting positions.