Add support for build_extensions configuration of builders producing multiple files
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g multiple files
d-markey
added a commit
to d-markey/squadron_builder
that referenced
this pull request
Feb 19, 2023
- Breaking changes: several renamings, in particular the builder name which is now `squadron_builder:worker_builder`. - Take builder options into account. In previous versions, builder options were ignored. Note that `source_gen` currently rejects builder configurations with multiple targets. Pull request dart-lang/source_gen#647 has been submitted to `source_gen` to support builders that produce multiple files. - Added explicit option `with_finalizers` to force or disable code generation for finalization, and make finalization actually work. - Split `build.yaml` in two to avoid interfering with the build process of client packages. - Reorganized the source code to make it more readable and maintainable.
natebosch
approved these changes
Feb 21, 2023
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
|
Hello, thanks for the merge, I'd like to know also if you have any timeline in mind for releasing an update on pub.dev? |
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…g multiple files (dart-lang/source_gen#647) Allow lists or single strings in the options.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…g multiple files (dart-lang/source_gen#647) Allow lists or single strings in the options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validatedBuildExtensionsFrom()inutils.jscurrently rejectsbuild_extensionsconfigurations that use a list of strings rather than a single string.This PR adds support for lists of strings.