Configurable outputs for the combining builder #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Aug 17, 2021
jakemac53
reviewed
Aug 18, 2021
jakemac53
reviewed
Aug 18, 2021
jakemac53
approved these changes
Aug 18, 2021
|
I filed dart-lang/sdk#46939 for the analyzer failure, we may need to mark that test as skipped for now. Or possibly we should make the test smart enough to not complain about these warnings? It will break for every new minor sdk version. |
simolus3
force-pushed
the
configure-output-extensions
branch
from
f947944 to
76566af
Compare
|
It works with the newest analyzer, I've fixed deprecation warnings which requires using the latest version as a lower bound. I agree that we should eventually make the tests more reliable, I also had some of them failing when running in isolation because of the "Generating SDK summary" logs. |
jakemac53
reviewed
Aug 19, 2021
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
) This adds support for custom output locations, including outputs in different directories, to the combining builder. - Make output extensions configurable through builder options. The options are validated to ensure the combining builder is running on Dart files and emits Dart files - Move the check ensuring we have a `part` statement from the `SharedPartBuilder` to the `CombiningBuilder`. The former can't know the correct output location anymore. This is related to dart-lang/source_gen#272, where the implementation in `build` requires cooperation from builders. Given that most generated files come from shared part generators in practice, this would enable generating to different folders for most users.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
) This adds support for custom output locations, including outputs in different directories, to the combining builder. - Make output extensions configurable through builder options. The options are validated to ensure the combining builder is running on Dart files and emits Dart files - Move the check ensuring we have a `part` statement from the `SharedPartBuilder` to the `CombiningBuilder`. The former can't know the correct output location anymore. This is related to dart-lang/source_gen#272, where the implementation in `build` requires cooperation from builders. Given that most generated files come from shared part generators in practice, this would enable generating to different folders for most users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for custom output locations, including outputs in different directories, to the combining builder.
partstatement from theSharedPartBuilderto theCombiningBuilder. The former can't know the correct output location anymore.This is related to #272, where the implementation in
buildrequires cooperation from builders. Given that most generated files come from shared part generators in practice, this would enable generating to different folders for most users.