Remove some analyzer ast and src imports #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `LibraryElement.exportNamespace` to find types across a libraries entire visible surface area rather than referencing a `NamespaceBuilder`. - Use the different getters for element typs from `CompilationUnitElement` to get all members of a library rather than getting the declarations from a `CompilationUnit`. - Increase minimum anlayzer version to ensure that the `mixins` getter is available.
scheglov
approved these changes
Oct 20, 2018
kevmoo
reviewed
Oct 20, 2018
| for (var compUnitMember in cu.unit.declarations) { | ||
| yield* _getElements(compUnitMember); | ||
| } | ||
| yield* cu.accessors; |
There was a problem hiding this comment.
It'd be GREAT if analyzer had an API for this ( CC @scheglov @bwilkerson ) – could we get a TODO in here w/ a feature request?
These are places where things fall apart for weird reasons if things are reclassified, etc...
There was a problem hiding this comment.
Filed dart-lang/sdk#34892
kevmoo
reviewed
Oct 20, 2018
source_gen/pubspec.yaml
Outdated
| @@ -1,12 +1,12 @@ | |||
| name: source_gen | |||
| version: 0.9.1+3 | |||
| version: 0.9.2-dev | |||
| author: Dart Team <[email protected]> | |||
| description: Automated source code generation for Dart. | |||
| homepage: https://github.com/dart-lang/source_gen | |||
| environment: | |||
| sdk: '>=2.0.0-dev.64.0 <3.0.0' | |||
There was a problem hiding this comment.
Might as well drop 2.0.0-dev version support while you're at it...
kevmoo
reviewed
Oct 20, 2018
| import 'package:analyzer/dart/element/element.dart'; | ||
| // ignore: implementation_imports | ||
| import 'package:analyzer/src/dart/resolver/scope.dart'; |
jakemac53
reviewed
Oct 22, 2018
| ClassElement findType(String name) { | ||
| var type = element.exportNamespace.get(name); | ||
| return type is ClassElement ? type : null; | ||
| } | ||
|
|
||
| /// All of the declarations in this library. | ||
| Iterable<Element> get allElements sync* { | ||
| for (var cu in element.units) { |
There was a problem hiding this comment.
So units is fine but unit isn't?
There was a problem hiding this comment.
Yup, one gives CompilationUnitElement and the other CompilationUnit.
|
Yes. Members that access elements from the element model are safe; members
that access the AST from the element model are not.
…On Mon, Oct 22, 2018 at 7:17 AM Jacob MacDonald ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In source_gen/lib/src/library.dart
<#384 (comment)>:
> /// Returns a top-level [ClassElement] publicly visible in by [name].
///
/// Unlike [LibraryElement.getType], this also correctly traverses identifiers
/// that are accessible via one or more `export` directives.
- ClassElement findType(String name) =>
- element.getType(name) ?? _namespace.get(name) as ClassElement;
+ ClassElement findType(String name) {
+ var type = element.exportNamespace.get(name);
+ return type is ClassElement ? type : null;
+ }
/// All of the declarations in this library.
Iterable<Element> get allElements sync* {
for (var cu in element.units) {
So units is fine but unit isn't?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#384 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFkeqxqo_pcHihNrrJuPSXAlOz09xwDoks5undOGgaJpZM4Xxm_n>
.
|
jakemac53
approved these changes
Oct 22, 2018
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
- Use `LibraryElement.exportNamespace` to find types across a libraries entire visible surface area rather than referencing a `NamespaceBuilder`. - Use the different getters for element types from `CompilationUnitElement` to get all members of a library rather than getting the declarations from a `CompilationUnit`. - Increase minimum analyzer version to ensure that the `mixins` getter is available.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
- Use `LibraryElement.exportNamespace` to find types across a libraries entire visible surface area rather than referencing a `NamespaceBuilder`. - Use the different getters for element types from `CompilationUnitElement` to get all members of a library rather than getting the declarations from a `CompilationUnit`. - Increase minimum analyzer version to ensure that the `mixins` getter is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibraryElement.exportNamespaceto find types across a librariesentire visible surface area rather than referencing a
NamespaceBuilder.CompilationUnitElementto get all members of a library rather thangetting the declarations from a
CompilationUnit.mixinsgetteris available.