Fix incorrect code in inference using bounds #6474
Conversation
The function calls were using the wrong name, first example was missing its argument. I believe the intention was to pass in a `List<int>`, perhaps `[1]`.
There was a problem hiding this comment.
That's correct! The function was named f1 because there was another one (f2) illustrating the "before" and "after" version of the static analysis. It was abbreviated and the function was renamed, and the mistakes were introduced at that point. Thanks!
Some background can be seen here: https://github.com/dart-lang/site-www/pull/6403/files/020b98ff0944a7368e648ff6ca0c8bc1f43d30f6#diff-d028b328d07abdc9a45ebc82b5227850fac5c6c61725226f87d4ee515e4333c4, in the comment on line 405 of 'type-system.md'.
|
@antfitch, I'm happy about these changes. However, I'm not in the team that normally makes the final decision about site-www PRs, could you take a look? |
Absolutely. Feel free to approve all of these moving forward, but I definitely think we need an editor to give the final okay & merge. |
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 3d2ed9a): |
The function calls were using the wrong name, first example was missing its argument. I believe the intention was to pass in a
List<int>, perhaps[1].