Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frog warns about things I cannot do anything about #875

Closed
peter-ahe-google opened this issue Dec 15, 2011 · 6 comments
Closed

frog warns about things I cannot do anything about #875

peter-ahe-google opened this issue Dec 15, 2011 · 6 comments

Comments

@peter-ahe-google
Copy link
Contributor

/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/date.dart:10:35: warning: factory no longer supported, use "default" instead
interface Date extends Comparable factory DateImplementation {
                                  ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/duration.dart:10:39: warning: factory no longer supported, use "default" instead
interface Duration extends Comparable factory DurationImplementation {
                                      ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/exceptions.dart:10:21: warning: factory no longer supported, use "default" instead
interface Exception factory ExceptionImplementation {
                    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/future.dart:23:21: warning: factory no longer supported, use "default" instead
interface Future<T> factory FutureImpl<T> {
                    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/future.dart:97:24: warning: factory no longer supported, use "default" instead
interface Completer<T> factory CompleterImpl<T> {
                       ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/isolate.dart:57:23: warning: factory no longer supported, use "default" instead
interface ReceivePort factory ReceivePortFactory {
                      ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/list.dart:9:41: warning: factory no longer supported, use "default" instead
interface List<E> extends Collection<E> factory ListFactory {
                                        ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/map.dart:9:21: warning: factory no longer supported, use "default" instead
interface Map<K, V> factory HashMapImplementation/<K extends Hashable, V>/ {
                    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/map.dart:98:5: warning: factory no longer supported, use "default" instead
    factory HashMapImplementation {
    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/map.dart:117:5: warning: factory no longer supported, use "default" instead
    factory LinkedHashMapImplementation {
    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/promise.dart:8:22: warning: factory no longer supported, use "default" instead
interface Promise<T> factory PromiseImpl<T> {
                     ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/promise.dart:93:39: warning: factory no longer supported, use "default" instead
interface Proxy extends Promise<bool> factory ProxyImpl {
                                      ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/queue.dart:10:42: warning: factory no longer supported, use "default" instead
interface Queue<E> extends Collection<E> factory DoubleLinkedQueue<E> {
                                         ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/regexp.dart:92:34: warning: factory no longer supported, use "default" instead
interface RegExp extends Pattern factory JSSyntaxRegExp {
                                 ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/set.dart:10:5: warning: factory no longer supported, use "default" instead
    factory HashSetImplementation {
    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/set.dart:73:5: warning: factory no longer supported, use "default" instead
    factory HashSetImplementation {
    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/stopwatch.dart:8:21: warning: factory no longer supported, use "default" instead
interface Stopwatch factory StopwatchImplementation {
                    ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/string.dart:11:56: warning: factory no longer supported, use "default" instead
interface String extends Comparable, Hashable, Pattern factory Strings {
                                                       ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/string_buffer.dart:10:24: warning: factory no longer supported, use "default" instead
interface StringBuffer factory StringBufferImpl {
                       ^^^^^^^
/Users/ahe/Dart/all/dart.googlecode.com/dart/corelib/src/time_zone.dart:10:20: warning: factory no longer supported, use "default" instead
interface TimeZone factory TimeZoneImplementation {
                   ^^^^^^^

@dgrove
Copy link
Contributor

dgrove commented Dec 20, 2011

Set owner to @jmesserly.

@jmesserly
Copy link

This will be fixed once corelib is updated. Should happen in the next day or two. Once it does the warnings will go away. (And I'll delete the code that supports the old-style factories--but we need the code now, otherwise corelib would break).

Regis, Eric, I saw a change go in for DartC support of new factories, does that mean corelib will be updated soon? I'd be happy to check it in if DartC is ready--I still Regis's corelib changes on my machine.


cc @crelier.

@peter-ahe-google
Copy link
Contributor Author

The point I was trying to make is that it is not in "your" users' interest to bury them in warnings.

The Dart language will continue to fluctuate until we ship version 1.0. I can only hope that similar situations will be handled more elegantly in the future and I hope the developers will try to evaluate the intermediate solutions from the perspective of their users.

@DartBot
Copy link

DartBot commented Dec 20, 2011

This comment was originally written by [email protected]


Should be fixed as of r2629. I committed the corelib changes from http://codereview.chromium.org/8931011/ to get rid of the keyword 'factory' in the interface specifications.

@jmesserly
Copy link

Awesome! Thanks Eric


Removed the owner.
Added Fixed label.

@jmesserly
Copy link

Awesome! Thanks Eric

copybara-service bot pushed a commit that referenced this issue Feb 23, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/dba6f94..e4cdbd6):
  e4cdbd6f  2023-02-21  Janice Collins  Record rendering simplification (#3344)

http (https://github.com/dart-lang/http/compare/c13a3f8..1500a71):
  1500a71  2023-02-23  Devon Carew  contribute a pull request labeler workflow (#875)
  e2c4e6f  2023-02-21  Brian Quinlan  Add a link to cronet_http_embedded from cronet_http. (#874)

markdown (https://github.com/dart-lang/markdown/compare/4befe66..ecbffa9):
  ecbffa9  2023-02-22  Kevin Moore  Use latest lints, require Dart 2.19 or later (#524)

shelf (https://github.com/dart-lang/shelf/compare/707c8b2..e3cfe79):
  e3cfe79  2023-02-22  Devon Carew  contribute issue templates and a pull request labeler (#332)

test (https://github.com/dart-lang/test/compare/e56c643..2cc4144):
  2cc4144e  2023-02-22  Nate Bosch  Avoid exceptions for iterable getters (#1954)
  f7fe4f06  2023-02-22  Nate Bosch  Include stack trace for exception in has (#1953)
  ba8e43af  2023-02-22  Nate Bosch  Only grab the first failure in softCheck (#1949)
  34df652b  2023-02-22  Nate Bosch  Flush stdin before test (#1950)
  ae015ef6  2023-02-22  Nidal Bakir  Add Concurrency Testing section to README (#1944)
  4e23d036  2023-02-21  Nate Bosch  Mention .having and .has in migration guide (#1948)
  438c2274  2023-02-21  Nate Bosch  Annotate `has` with `@useResult` (#1947)
  3ddecafd  2023-02-21  Nate Bosch  Add async examples to README (#1946)

tools (https://github.com/dart-lang/tools/compare/a53933c..c7518f7):
  c7518f7  2023-02-22  Elias Yishak  Update to regex to look for underscore delimited labels (#12)

webdev (https://github.com/dart-lang/webdev/compare/ae7eb80..1e7f9b7):
  1e7f9b7  2023-02-22  Anna Gringauze  Create copying sdk configuration provider (#1984)
  26910ba  2023-02-22  Anna Gringauze  Pass SdkLayout to the frontend server (#1986)
  784e28b  2023-02-22  Anna Gringauze  Remove unnecessary awaits (#1982)
  3cbaf37  2023-02-22  Elliott Brooks (she/her)  [MV3 Debug Extension] Support Bolt workflow (#1983)
  0f893e6  2023-02-22  Anna Gringauze  Move project definitions into a separate class (#1975)
  a942b5f  2023-02-22  Anna Gringauze  Add unnecessary_lambdas lint (#1978)
  3774cf8  2023-02-21  Anna Gringauze  Add 'avoid_void_async' lint (#1977)
  705e0ac  2023-02-21  Elliott Brooks (she/her)  [MV3 Debug Extension] Show a warning if multiple Dart apps are in a single page (#1976)

Change-Id: Iea264a18a154e71cd0990e1363951648bec5ceba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284940
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants