Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unsafe_html #57099

Closed
13 of 15 tasks
srawlins opened this issue Jun 18, 2024 · 2 comments
Closed
13 of 15 tasks

Deprecate unsafe_html #57099

srawlins opened this issue Jun 18, 2024 · 2 comments
Assignees
@srawlins
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@srawlins
Copy link
Member

srawlins commented Jun 18, 2024 •
edited
Loading

I don't think this rule has provided any value outside Google. It is still the only subclass of SecurityLintRule. We can move it wholesale to be an internal rule, and reduce the maintenance burden as a public rule.
@srawlins srawlins added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P2 A bug or feature request we're likely to work on labels Jun 18, 2024
@srawlins
Copy link
Member Author

WDYT, @bwilkerson @pq

@srawlins srawlins self-assigned this Oct 24, 2024
This was referenced Oct 24, 2024
Closed
Merged
Closed
Merged
srawlins referenced this issue in srawlins/dart-rfb Oct 29, 2024
@srawlins
Disable two lint rules which are being removed.
44f8497 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
This was referenced Oct 29, 2024
Merged
Merged
srawlins referenced this issue in srawlins/flutter-rfb Oct 29, 2024
@srawlins
Disable two lint rules which are being removed.
49687fd 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins srawlins mentioned this issue Oct 29, 2024
Merged
srawlins referenced this issue in srawlins/flutter_portal Oct 29, 2024
@srawlins
Disable two lint rules which are being removed.
b5b3ab9 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins srawlins mentioned this issue Oct 29, 2024
Merged
srawlins referenced this issue in srawlins/flutter-packages Oct 30, 2024
@srawlins
Disable two lint rules which are being removed.
ba308d1 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins srawlins mentioned this issue Oct 30, 2024
Merged
11 tasks
auto-submit bot referenced this issue in flutter/packages Oct 30, 2024
@srawlins
Disable two lint rules which are being removed. (#7959)
e12e073 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
srawlins referenced this issue in flutter/devtools Oct 31, 2024
@srawlins
Disable two lint rules which are being removed. (#8488)
80a71da 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
mossmana referenced this issue in mossmana/devtools Oct 31, 2024
@srawlins @mossmana
Disable two lint rules which are being removed. (flutter#8488)
cf84876 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
auto-submit bot referenced this issue in flutter/cocoon Nov 1, 2024
@srawlins
Disable three lint rules which are being removed. (#3991)
ded610e 
Each of these three are going to be removed soon.

* avoid_null_checks_in_equality_operators
* package_api_docs
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
srawlins referenced this issue in flutter/tests Nov 6, 2024
@srawlins
Bump flutter_cocoon to ded610ea7563cff50efa6efaeeb14d69848382c0
ecb6422 
ded610ea7563cff50efa6efaeeb14d69848382c0 contains flutter/cocoon#3991 which unblocks https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
This was referenced Nov 6, 2024
Merged
Merged
srawlins referenced this issue in flutter/tests Nov 6, 2024
@srawlins
Bump flutter_portal to 5584f9bbd5f7dcbc46e3293e395978466c83a453
cdae6f5 
5584f9bbd5f7dcbc46e3293e395978466c83a453 contains fzyzcjy/flutter_portal#117, which unblocks https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins srawlins mentioned this issue Nov 6, 2024
Merged
8 tasks
auto-submit bot referenced this issue in flutter/tests Nov 6, 2024
@srawlins
Bump flutter_cocoon to ded610ea7563cff50efa6efaeeb14d69848382c0 (#423)
9506dcd 
ded610ea7563cff50efa6efaeeb14d69848382c0 contains flutter/cocoon#3991 which unblocks https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
auto-submit bot referenced this issue in flutter/tests Nov 6, 2024
@srawlins
Bump assorted_layout_widgets to e32fabf854927bb4c0c0284624bf30c20c4aa…
d85ff4e 
…b8d (#422)

e32fabf854927bb4c0c0284624bf30c20c4aab8d includes marcglasberg/assorted_layout_widgets#34, a fix to unblock removing the `unsafe_html` lint rule, https://github.com/dart-lang/linter/issues/5001
auto-submit bot referenced this issue in flutter/tests Nov 6, 2024
@srawlins
Bump flutter_portal to 5584f9bbd5f7dcbc46e3293e395978466c83a453 (#424)
96449e0 
5584f9bbd5f7dcbc46e3293e395978466c83a453 contains fzyzcjy/flutter_portal#117, which unblocks https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins srawlins mentioned this issue Nov 6, 2024
Merged
8 tasks
auto-submit bot referenced this issue in flutter/tests Nov 7, 2024
@srawlins
Disable the dart_rfb and flutter_rfb tests (#425)
1344f3d 
Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001

There are open PRs for blocked Dart SDK work in these two repos:

* Goddchen/dart-rfb#26
* Goddchen/flutter-rfb#24

@Goddchen has not responded to these in 72 hours. This change disables the tests. The tests can be re-enabled when those PRs have been merged, and the subsequent relevant commits in this repo bumped.
copybara-service bot referenced this issue Nov 8, 2024
@srawlins
linter: Remove unsafe_html rule
cb5c73e 
Fixes https://github.com/dart-lang/linter/issues/5001

Change-Id: I972ea8f9fafda88b6a4836ab92107cebe8a6ad4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391303
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Goddchen referenced this issue in Goddchen/dart-rfb Nov 13, 2024
@srawlins
Disable two lint rules which are being removed. (#26)
8e62ccf 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins
Copy link
Member Author

The unsafe_html rule is successfully removed.

@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 15, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 15, 2024
mockturtl added a commit to mockturtl/tidy that referenced this issue Jan 18, 2025
@mockturtl
fix: remove unsafe_html
7130caa 
dart-lang/sdk#57099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @devoncarew