Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing FFI tests on CFE #51958

Open
leafpetersen opened this issue Apr 5, 2023 · 3 comments
Open

Failing FFI tests on CFE #51958

leafpetersen opened this issue Apr 5, 2023 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi

Comments

@leafpetersen
Copy link
Member

The following ffi co19 tests are currently failing on the CFE (but not the analyzer). The failures do not seem related to the class modifier feature, which is only used incidentally there.

co19/LibTest/ffi/Array/Array.multi_A01_t02
co19/LibTest/ffi/Array/Array.multi_A02_t01
co19/LibTest/ffi/Array/Array.multi_A02_t02
co19/LibTest/ffi/Array/Array.multi_A03_t02
co19/LibTest/ffi/Array/Array.multi_A03_t04
co19/LibTest/ffi/Array/Array_A02_t01
co19/LibTest/ffi/Array/Array_A02_t02
co19/LibTest/ffi/Array/Array_A03_t02
co19/LibTest/ffi/Array/Array_A03_t04
co19/LibTest/ffi/Struct/Struct_A02_t01
co19/LibTest/ffi/Union/Union_A03_t01
co19/LibTest/ffi/Union/Union_A03_t02
co19/LibTest/ffi/Union/Union_A03_t03
co19/LibTest/ffi/Union/Union_A04_t01

cc @dcharkes @johnniwinther
@johnniwinther
Copy link
Member

Looking at the first test it looks like it is only a matter where the error is reported. If so, the tests just need to be updated.

@dcharkes can you take a deeper look into this?

@dcharkes
Copy link
Contributor

dcharkes commented Apr 5, 2023

List of tests with logs: https://dart-ci.firebaseapp.com/current_results/#/filter=co19/LibTest/ffi

copybara-service bot pushed a commit that referenced this issue Apr 5, 2023
@dcharkes
[cfe/ffi] Error on 0-size array
8765f93 
TEST=co19/LibTest/ffi/Array/Array.multi_A02_t01

Bug: #51958
Closes: #45540
Change-Id: I33f84b829968f7f8496710c6facaa489b741b2fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293600
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Daco Harkes <[email protected]>
@johnniwinther
Copy link
Member

@dcharkes Have you filled co19 issues for the tests that need updates?

@dcharkes dcharkes mentioned this issue Apr 5, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Apr 5, 2023
@dcharkes
[cfe/ffi] Fix compiler crash on invalid Array type
4b5401b 
And report error on invalid type nested in `Array`.

TEST=co19/LibTest/ffi/Array/Array.multi_A03_t02
TEST=co19/LibTest/ffi/Array/Array.multi_A03_t04
TEST=co19/LibTest/ffi/Array/Array_A03_t02
TEST=co19/LibTest/ffi/Array/Array_A03_t04

Bug: #51958
Change-Id: Ida650f2c7c93ebce8c93a1dc5a5b4b222166438b
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293601
Reviewed-by: Johnni Winther <[email protected]>
@srawlins srawlins added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Apr 5, 2023
This was referenced Apr 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @dcharkes @leafpetersen @johnniwinther