Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to implement a proper scheme to deal with errors when writing or reading a message in an isolate #5060

Closed
a-siva opened this issue Sep 10, 2012 · 7 comments
Closed

Need to implement a proper scheme to deal with errors when writing or reading a message in an isolate #5060

a-siva opened this issue Sep 10, 2012 · 7 comments
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report
Milestone
M5

Comments

@a-siva
Copy link
Contributor

a-siva commented Sep 10, 2012

Currently we have numerous asserts in the code which write or read messages in an Isolate. These asserts should be converted to errors and we need a
proper scheme for isolates to be able to handle errors when reading
or writing messages.

One potential possibility is to report the errors and let the API code
deal with it.
@a-siva
Copy link
Contributor Author

a-siva commented Sep 10, 2012

Issue #466 has been merged into this issue.

cc @kasperl.

@a-siva
Copy link
Contributor Author

a-siva commented Sep 11, 2012

Added Area-VM label.

@a-siva
Copy link
Contributor Author

a-siva commented Dec 7, 2012

We already have the mechanism to report errors when reading or writing messages.

The various ASSERTS need to be converted to return errors.

@iposva-google
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@iposva-google
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@a-siva
Copy link
Contributor Author

a-siva commented Jun 4, 2013

Added Duplicate label.
Marked as being merged into #1747.

@a-siva a-siva added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report labels Jun 4, 2013
@a-siva a-siva self-assigned this Jun 4, 2013
@a-siva a-siva added this to the M5 milestone Jun 4, 2013
This was referenced Jun 3, 2015
Closed
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
M5
Development

No branches or pull requests
3 participants
@iposva-google @larsbak @a-siva