Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive ports are not translated to the send ports #437

Closed
DartBot opened this issue Nov 14, 2011 · 5 comments
Closed

receive ports are not translated to the send ports #437

DartBot opened this issue Nov 14, 2011 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-as-intended Closed as the reported issue is expected behavior
Milestone

Comments

@DartBot
Copy link

DartBot commented Nov 14, 2011

This issue was originally filed by [email protected]


Description of SendPort.send() says:

If the message contains any receive ports, they are translated to the corresponding send port before being transmitted.

Actually this not happen, receive ports remain instanses of ReceivePortImpl.
Moreover, if the message is ReceivePort itself, dart_bin VM crashes.

What steps will reproduce the problem?
run co19 tests
LibTest/core/SendPort/send/SendPort/send/A02/t01
LibTest/core/SendPort/send/SendPort/send/A02/t02

What is the expected output? What do you see instead?
tests should pass

What version of the product are you using? On what operating system?
dart_bin build from svn revision 1499, Linux

Please provide any additional information below.

@DartBot
Copy link
Author

DartBot commented Nov 15, 2011

This comment was originally written by [email protected]


Added Area-VM, Triaged labels.

@iposva-google
Copy link
Contributor

Set owner to @a-siva.

@a-siva
Copy link
Contributor

a-siva commented Feb 24, 2012

After discussion with Kasper we decided that the functionality of automatically translating receive ports to the corresponding send ports is incorrect. The documentation in the function is incorrect and will be changed.

Also we should be throwing an exception when code tries to send a message that has a receive port in it.

@iposva-google
Copy link
Contributor

Added Accepted label.

@a-siva
Copy link
Contributor

a-siva commented Sep 10, 2012

The documentation in SendPort.send has been fixed to indicate that it is not legal
to send receive ports in a message.
The co19 tests above have also been updated to reflect this.

The aspect of the VM correctly reporting error messages when illegal objects are
sent in a message will be handled as part of issue #5060.


Added this to the M1 milestone.
Added AsDesigned label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-as-intended Closed as the reported issue is expected behavior
Projects
None yet
Development

No branches or pull requests

3 participants