-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the uri
property of RedirectException
nullable
#49045
Comments
//cc @lrhn |
I didn't find any usages of |
@grouma If you are referring to the |
I have no opinion on this change. |
@vsmenon It's all up to you ;-) |
lgtm |
Fixed in e5af733 |
Bug: #49045 Change-Id: I9ac976545c0505a20a90f12333a424d0ed8cf96f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247820 Commit-Queue: Brian Quinlan <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]>
Change
Change:
Rationale
This will allow us to cleanly fix #49012, which causes a
StateError
when there is no availableuri
.Impact
This will only break code that uses the
RedirectException
class directly and does not handle thenull
uri
case.Code that works with the
HttpException
base class will not need to be changed becauseuri
is already nullable in that class.This change does not break any Google code or any third-party code used by Google.
Mitigation
Users must handle a possible
null
return fromRedirectException.uri
.The text was updated successfully, but these errors were encountered: