Generalize browser support in the infrastructure #42417
Assignees
Labels
area-infrastructure
Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Comments
athomas
added
the
area-infrastructure
dart-bot
pushed a commit
that referenced
this issue
Jun 24, 2020
The browser used by the test infrastructure are currently pulled in from the recipes rather than via gclient. This is the first step to remove that duplicated functionality and will enable all builders to that need browser to get them. The browsers aren't downloaded by default and not available on all platforms. It is not recommend to use these browsers for local testing, because they may interfere with a user's installation. #42417 Change-Id: I5df72c3b43f7b49cf90200d47a089714c91b5b3f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152340 Auto-Submit: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Commit-Queue: William Hesse <[email protected]> Reviewed-by: William Hesse <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Jun 25, 2020
#42417 Change-Id: If678cb418df7b15f98aa2ad49818c908c24089bc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152502 Auto-Submit: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]> Commit-Queue: William Hesse <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Jul 7, 2020
This adds a CHROME_PATH or FIREFOX_PATH environment variable to the test's evnironment which contains a path to the browser's executable. This is only set if the --chrome or --firefox argument was passed to test.py. #42417 Change-Id: I711de6ab91b8ffbbe72c7fb1530b68c4189a4b8a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153209 Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Jul 8, 2020
…n present" This reverts commit 40c79c8. Reason for revert: Breaks on windows. Original change's description: > [test] Add paths to chrome and firefox to the environment when present > > This adds a CHROME_PATH or FIREFOX_PATH environment variable to the > test's evnironment which contains a path to the browser's executable. > This is only set if the --chrome or --firefox argument was passed to > test.py. > > #42417 > > Change-Id: I711de6ab91b8ffbbe72c7fb1530b68c4189a4b8a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153209 > Commit-Queue: Alexander Thomas <[email protected]> > Reviewed-by: William Hesse <[email protected]> [email protected],[email protected] Change-Id: I7e1351f9b170ae3ddd218055efb770fe6e1f54e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153606 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Jul 10, 2020
This should land after the corresponding recipe change landed: https://dart-review.googlesource.com/c/recipes/+/153120 #42417 Change-Id: I0eb569e3b0c9c1d401c7924b5e021b259e6638a4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153206 Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Jul 10, 2020
…n present" This is a reland of 40c79c8 The build recipes now use forward slashes on Windows to pass the path to the browser executable to test.py. Original change's description: > [test] Add paths to chrome and firefox to the environment when present > > This adds a CHROME_PATH or FIREFOX_PATH environment variable to the > test's evnironment which contains a path to the browser's executable. > This is only set if the --chrome or --firefox argument was passed to > test.py. > > #42417 > > Change-Id: I711de6ab91b8ffbbe72c7fb1530b68c4189a4b8a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153209 > Commit-Queue: Alexander Thomas <[email protected]> > Reviewed-by: William Hesse <[email protected]> Change-Id: Ib61b8c6424fa7bce525d76d8b94756a215d28c1e Cq-Include-Trybots: dart/try:dart2js-strong-win-x64-chrome-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153980 Commit-Queue: Alexander Thomas <[email protected]> Commit-Queue: William Hesse <[email protected]> Auto-Submit: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
|
This is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
download_chrometo pkg builders (https://dart-review.googlesource.com/c/sdk/+/152502).The text was updated successfully, but these errors were encountered: