VM doesn't fully treat get as a pseudo keyword

[DartBot]

This issue was originally filed by [email protected]

---

I've recently fixed a bug in frog to allow get and set to be used as member names - as I believe they are allowed by the spec. When I tried to use this feature in the frog compiler, I got a parse error from the VM.

I believe that this should be allowed by the spec and is one of the most useful things that we get out of the otherwise somewhat interesting decision to include pseudo-keywords in a v1 language spec. I'd love to get a fix for this, but even more valuable would be a quick response to let me know if you do consider this a bug in the VM or if it is my misreading of the spec. The High priority is just to verify if this is or is not a VM bug - so that I don't take frog down the wrong road. The actual fix is a much lower priority as this is easy enough to work around.

The code that is responsible for the error is this method declaration in frog/value.dart (Note: not currently checked in as that would break our VM tests <smile>).

    Value get(MethodGenerator context, String name, Node node) { ... }

Errors encountered while loading script: '/Users/jimhug/dartfrog/dart/frog/frogc.dart': Error: line 6 pos 1: library handler failed: '/Users/jimhug/dartfrog/dart/frog/lang.dart': Error: line 26 pos 1: library handler failed: '/Users/jimhug/dartfrog/dart/frog/value.dart': Error: line 34 pos 12: identifier expected
  Value get(MethodGenerator context, String name,

import('lang.dart');

^

[DartBot]

This comment was originally written by @mhausner

---

This is currently a bug in the VM.

My main concern is that with allowing get and set to be "pseudo-keywords", the semantics of

get f() { ... }

are unclear. Is this a function f returning a value of type get, or is it a getter f that has no return type specified.

[DartBot]

This comment was originally written by [email protected]

---

Thanks for the quick reply!

I think that your concern is resolved by the current behavior of the VM on PseudoKWNegativeTest. This prohibits the use of pseudo keywords as type names - but not as member names. I've opened a separate issue #356 to track this one, but I hope that we can resolve that issue in favor of the current VM behavior and address this ambiguity at the same time. Of course, if someone wanted to just make all of the current dart keywords true keywords for the v1 release I would also be very supportive of that change.

---

Removed Priority-High label.
Added Priority-Medium label.

[DartBot]

This comment was originally written by @mhausner

---

The behavior currently implemented in the VM reflects the understanding we had earlier in the year that pseudo-keywords are proper keywords "at the top level", that is outside of a function block. From this it follows that get or set can be used as local variable names, but not as type, function, field or parameter name.

The spec does say something different than what I describe above. Gilad will revisit the issue.

Personally, I'd love to see all pseudo-keywords be proper keywords.

[iposva-google]

Over to Gilad to clarify.

---

Set owner to @gbracha.
Removed Area-VM label.
Added Area-Language, Accepted labels.

[gbracha]

The spec now disallows built-in identifiers as types, but tolerates them with warnings otherwise. Using them is terrible style, and the warnings are no doubt enough to annoy anyone who likes the idea. The only reason for tolerating this usage is to ease conversion from other languages (mainly JS).

---

Added Done label.