Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer: fix up break/continue in switch statement using labels #3658

Closed
DartBot opened this issue Jun 14, 2012 · 3 comments
Closed

Analyzer: fix up break/continue in switch statement using labels #3658

DartBot opened this issue Jun 14, 2012 · 3 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Milestone

Comments

@DartBot
Copy link

DartBot commented Jun 14, 2012

This issue was originally filed by [email protected]


See test failures for language/switch_label_test and language/switch7_negative_test

class Switch7NegativeTest {

  static testMain() {
     var x = 1;
     L: while (true) {
       switch (x) {
         L: case 1: // Shadowing another label is OK.
            break L; // illegal, can't reference labeled case stmt from break
       }
     }
  }
}

main() {
  Switch7NegativeTest.testMain();
}

and the other case looks like:

   switch (sound) {
      MOO:
      case "moo":
        x = 100;
        break;
      case "woof":
        x = 200;
        continue MOO; // analyzer emits compile-time error
      default:
        x = 300;
        break;
    }

@DartBot
Copy link
Author

DartBot commented Jun 28, 2012

This comment was originally written by [email protected]


Set owner to [email protected].

@DartBot
Copy link
Author

DartBot commented Jun 28, 2012

This comment was originally written by [email protected]


https://chromiumcodereview.appspot.com/10725002


Added Started label.

@DartBot
Copy link
Author

DartBot commented Jun 28, 2012

This comment was originally written by [email protected]


r9220


Added Fixed label.

@DartBot DartBot added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Jun 28, 2012
@DartBot DartBot added this to the M1 milestone Jun 28, 2012
copybara-service bot pushed a commit that referenced this issue Nov 25, 2022
Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53

Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667)
 https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196)
 https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666)
 https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665)
 https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656)
 https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to
override stdout.hasTerminal for output animations (#3658)
 https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663)
 https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571)
 https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637)
 https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660)
 https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650)
 https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652)
 https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648)

```

Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/

Bump webdev to 637b406f325669507b5c1048c19a7c0083c1bd6e

Changes:
```
> git log --format="%C(auto) %h %s" 3ec168f..637b406
 https://dart.googlesource.com/webdev.git/+/637b406 Support `--native-assets` in `FrontendServerClient` (#1797)
 https://dart.googlesource.com/webdev.git/+/a19d563 Save debug information in `chrome.storage` after a Dart app loads  (#1791)
 https://dart.googlesource.com/webdev.git/+/9cc10d4 Connect to a `chrome.runtime` port to keep the service worker alive  (#1789)

```
Diff: https://dart.googlesource.com/webdev.git/+/3ec168f6815af9d5f11278111d147bc82c0755c3~..637b406f325669507b5c1048c19a7c0083c1bd6e/


Update CHANGELOG


Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53

Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667)
 https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196)
 https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666)
 https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665)
 https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656)
 https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to override stdout.hasTerminal for output animations (#3658)
 https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663)
 https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571)
 https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637)
 https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660)
 https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650)
 https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652)
 https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648)

```

Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/
Change-Id: I65b928479b44f08305853078b0f34a6b66602709
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271709
Auto-Submit: Sigurd Meldgaard <[email protected]>
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

1 participant